Review main Merged

81685[BUGFIX] Fix special characters in scheduler labels

Imko Schumacher CR +2 V +2 Easy +2 −2 updated 11/06/23, 17:40

Commit message

Special characters (e.g. ") in argument labels of console
commands are no longer displayed as HTML entity (").

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 910

  1. Imko Schumacher uploaded patch set 1 11/05/23, 17:58

  2. core-ci voted on patch set 1 V +1 11/05/23, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48595

  3. Benni Mack commented on patch set 1 11/06/23, 11:21

  4. Oliver Hader commented on patch set 1 11/06/23, 11:37

    Labels are used in Fluid templates as `{field.langLabel}` and thus are already encoded by Fluid. Looks good
  5. Oliver Hader voted on patch set 1 CR +1 11/06/23, 11:37

  6. Oliver Klee voted on patch set 1 CR +1 11/06/23, 11:58

  7. Garvin Hicking commented on patch set 1 V +1 CR +1 11/06/23, 13:55

    Checked other occurences of htmlspecialchars() within the ext, the others are all good. Getters don't seem to be called anywhere else. Good to go :-)
  8. Imko Schumacher commented on patch set 1 11/06/23, 16:59

    Reply

    No, this was already fixed by https://forge.typo3.org/issues/93888 . This bug was introduced by the refactoring in https://review.typo3.org/c/Packages/TYPO3.CMS/+/73051 .
  9. Oliver Hader voted on patch set 1 V +2 CR +2 11/06/23, 17:37

  10. Oliver Hader merged patch set 2 11/06/23, 17:40