Review main Merged

81692[TASK] Remove superfluous typecasts in Extbase AbstractValidator

Torben Hansen CR +2 V +2 Easy +2 −2 updated 11/06/23, 12:00

Commit message

Function arguments for `addErrorForProperty()` in Extbase
`AbstractValidator` do use PHP native types, so several
typecasts in the function are not required any more.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Torben Hansen uploaded patch set 1 11/06/23, 09:04

  2. core-ci voted on patch set 1 V +1 11/06/23, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48620

  3. Simon Schaufelberger voted on patch set 1 V +1 CR +1 11/06/23, 11:10

  4. Oliver Hader commented on patch set 1 11/06/23, 11:46

    Would apply to 12.4 as well
  5. Oliver Hader uploaded patch set 2 CR +1 V +1 11/06/23, 11:47

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 11/06/23, 11:49

  7. Simon Schaufelberger voted on patch set 2 V +1 CR +1 11/06/23, 11:53

  8. Oliver Hader voted on patch set 2 V +2 CR +2 11/06/23, 11:55

  9. core-ci voted on patch set 2 V +1 11/06/23, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48637

  10. Oliver Klee voted on patch set 2 V +1 CR +1 11/06/23, 11:57

  11. Oliver Hader merged patch set 3 11/06/23, 12:00