Review 12.4 Merged

81693[TASK] Remove superfluous typecasts in Extbase AbstractValidator

Oliver Hader CR +2 V +2 Easy +2 −2 updated 11/06/23, 12:00

Commit message

Function arguments for `addErrorForProperty()` in Extbase
`AbstractValidator` do use PHP native types, so several
typecasts in the function are not required any more.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Oliver Hader uploaded patch set 1 11/06/23, 11:48

  2. Oliver Hader voted on patch set 1 V +2 CR +2 11/06/23, 11:55

  3. Oliver Klee voted on patch set 1 V +1 CR +1 11/06/23, 11:57

  4. core-ci voted on patch set 1 V +1 11/06/23, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48638

  5. Oliver Hader merged patch set 2 11/06/23, 12:00