81704[BUGFIX] Prevent possible PHP crash with empty systemLocale
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1012
-
Xavier Perseguers uploaded patch set 1 11/07/23, 14:58
-
Benni Mack commented on patch set 1 CR +1 11/07/23, 15:05
looks good -
core-ci voted on patch set 1 V +1 11/07/23, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48692
-
Benni Mack commented on patch set 1 11/07/23, 15:06
CommandUtility.php:447I think we need the $currentLocale assignment into the if as well -
Xavier Perseguers commented on patch set 1 11/07/23, 15:23
CommandUtility.php:447ReplyNo, as the $currentLocale call cannot fail with argument '0' which doesn't set anything but return current configuration and it's used afterwards to "reset" the locale to the one defined globally. -
Xavier Perseguers commented on patch set 1 11/07/23, 15:24
CommandUtility.php:447Replyah, I see what you mean, but this should do any harm anyway. -
Xavier Perseguers uploaded patch set 2
CR +1V +111/07/23, 15:25 -
Xavier Perseguers commented on patch set 2 11/07/23, 15:26
this way we don't take any risk "breaking" something.CommandUtility.php:447ReplyDone -
core-ci voted on patch set 2 V +1 11/07/23, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48693
-
Garvin Hicking commented on patch set 2 V +1 CR +1 11/07/23, 16:16
Nice catch! :-) -
Benni Mack voted on patch set 2 V +2 CR +2 11/07/23, 16:19
-
Benni Mack merged patch set 3 11/07/23, 16:19