Review main Merged

81705[TASK] Use native PHP types in protected/internal GifBuilder methods

Benni Mack CR +2 V +2 Hard +267 −291 updated 11/08/23, 17:18

Commit message

This change cleans up GifBuilder class
further by adding types to all internal
or protected methods.

In addition, some cleanups are done:
* Renaming of `$OFFSET` to `$offset`
* Remove superfluous checks of `is_array()`

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1115

  1. Benni Mack uploaded patch set 1 11/07/23, 16:39

  2. core-ci voted on patch set 1 V -1 11/07/23, 16:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48696

  3. Benni Mack uploaded patch set 2 V -1 11/07/23, 20:54

  4. core-ci voted on patch set 2 V +1 11/07/23, 21:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48698

  5. Benni Mack uploaded patch set 3 V +1 11/08/23, 10:04

  6. core-ci voted on patch set 3 V +1 11/08/23, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48708

  7. Oliver Klee commented on patch set 3 11/08/23, 11:44

    GifBuilder.php:1501

    We need an int cast here - `max` casts for comparison, but the returned value is not cast (at least according to the docs https://www.php.net/manual/en/function.max.php).
  8. Oliver Klee uploaded patch set 4 V +1 11/08/23, 11:49

  9. Oliver Klee commented on patch set 3 11/08/23, 11:49

    GifBuilder.php:1501 Reply

    Done
  10. Oliver Klee voted on patch set 4 CR +1 11/08/23, 11:50

  11. core-ci voted on patch set 4 V +1 11/08/23, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48711

  12. Oliver Klee voted on patch set 4 V +1 11/08/23, 12:06

  13. Stefan Bürk voted on patch set 4 V +1 CR +1 11/08/23, 15:06

  14. Benni Mack voted on patch set 4 V +2 CR +2 11/08/23, 17:18

  15. Benni Mack merged patch set 5 11/08/23, 17:18