Review 11.5 Merged

81719[BUGFIX] Properly escalate if a form HMAC fails to decode

Benjamin Franzke CR +2 V +2 Normal +53 −2 updated 11/10/23, 12:48

Commit message

If a HMAC cannot be `json_decode`d (possibly due to old
saved pages or other outdated content), now a proper exception
is thrown instead of issuing a PHP warning.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Benjamin Franzke uploaded patch set 1 11/10/23, 12:29

  2. core-ci voted on patch set 1 V +1 11/10/23, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48790

  3. Benjamin Franzke voted on patch set 1 V +2 CR +2 11/10/23, 12:48

  4. Benjamin Franzke merged patch set 2 11/10/23, 12:48