81728[TASK] Position alert container at the bottom of the screen
Commit message
Review
-
Code review CR +2 Done
- Jasmina Ließmann +2
- Oli Bartsch +1
- Andreas Kienast +1
-
Verified V +2 Done
- Jasmina Ließmann +2
- Oli Bartsch +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1521
-
Marcin Sągol uploaded patch set 1 11/13/23, 19:20
-
core-ci voted on patch set 1 V -1 11/13/23, 19:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48868
-
Chris Müller updated the commit message in patch set 2
V -111/13/23, 19:58 -
core-ci voted on patch set 2 V -1 11/13/23, 20:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48873
-
Marcin Sągol uploaded patch set 3
V -111/13/23, 20:52 -
core-ci voted on patch set 3 V -1 11/13/23, 21:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48875
-
Rachel Foucard commented on patch set 3 CR -1 11/14/23, 07:46
Hello Marcin, Thank you for working on this patch. Centering the alert container won't solve the problem because other important action button will be hidden according the screen size. A lot of important action buttons or menu are generaly on the top of a screen. Usually, a flash message or snackbar should stand at the bottom of the screen (bottom / right for large screen, and bottom / center for mobile screen). With a bottom position, it is still easy to see and to interact with, and it is less likely to interfere with important menus or actions. Rachel -
Marcin Sągol uploaded patch set 4
CR -1V -111/15/23, 18:17 -
Marcin Sągol commented on patch set 4 11/15/23, 18:19
Reply
I have updated this patch. As you suggested i have moved the notifications container at the bottom. -
core-ci voted on patch set 4 V +1 11/15/23, 18:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48964
-
Rachel Foucard voted on patch set 4 CR +1 11/16/23, 07:54
-
Oli Bartsch commented on patch set 4 11/21/23, 21:05
I like the patch, however is suggest to skip this for v12 and introduce this only for v13. -
Oli Bartsch updated the commit message in patch set 5
CR +1V +111/21/23, 21:13 -
Oli Bartsch commented on patch set 5 V +1 CR +1 11/21/23, 21:13
Reply
We discussed this at the community code sprint and decided to not force such behaviour change to a released LTS version. We would like to get enough feedback for this change and therefore skip the backport. -
core-ci voted on patch set 5 V +1 11/21/23, 21:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49301
-
Jasmina Ließmann uploaded patch set 6
CR +1V +111/21/23, 21:42 -
core-ci voted on patch set 6 V +1 11/21/23, 21:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49307
-
Oli Bartsch voted on patch set 6 V +1 CR +1 11/22/23, 07:56
-
Andreas Kienast voted on patch set 6 V +1 CR +1 11/22/23, 08:50
-
Jasmina Ließmann voted on patch set 6 V +2 CR +2 11/22/23, 08:56
-
Jasmina Ließmann merged patch set 7 11/22/23, 08:56