81743[TASK] Make clearable button more accessible
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Willi Wehmeier +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Willi Wehmeier +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 6
- Build/Sources/Sass/typo3/_main_form.scss+8 −2
- Build/Sources/TypeScript/backend/input/clearable.ts+2 −1
- Build/Sources/TypeScript/install/renderable/clearable.ts+2 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+2 −1
- typo3/sysext/backend/Resources/Public/JavaScript/input/clearable.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/renderable/clearable.js+1 −1
Review log 1820
-
Patrick Schriner uploaded patch set 1 11/14/23, 13:19
-
core-ci voted on patch set 1 V +1 11/14/23, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48905
-
Oli Bartsch uploaded patch set 2
V +111/15/23, 11:41 -
Oli Bartsch voted on patch set 2 V +1 CR +1 11/15/23, 11:41
-
core-ci voted on patch set 2 V +1 11/15/23, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48953
-
Simon Schaufelberger commented on patch set 2 11/18/23, 20:06
Please adjust the "Form Management" module search field and the search form above the page tree as well because it doesn't work there. -
Patrick Schriner commented on patch set 2 11/20/23, 08:32
Reply
I'd love to, but that would be a pretty major change as the X comes from the type=search attribute https://medium.com/@rion.mrk/how-to-remove-x-icon-from-search-input-field-or-input-type-search-db3c808405fb It's not even showing in Firefox -
Simon Schaufelberger commented on patch set 2 11/21/23, 19:03
Reply
ok, but the Form Management input field should still be changed to be in line with the Beuser module for example -
Oli Bartsch commented on patch set 2 11/21/23, 19:24
Reply
As Patrick already mentioned. Using type=search, the clear button is rendered by the browser. We should not change the behaviour and I'm also for not changing the type, since type=search is obviously the correct type. -
Simon Schaufelberger commented on patch set 2 11/21/23, 19:25
Reply
Ack -
Simon Schaufelberger voted on patch set 2 V +1 CR +1 11/21/23, 19:25
-
Simon Schaufelberger commented on patch set 2 11/21/23, 19:25
Reply
I just wanted to make you aware that there are some inconsistencies. -
Willi Wehmeier voted on patch set 2 V +1 CR +1 11/21/23, 20:21
-
Christian Kuhn voted on patch set 2 V +2 CR +2 11/21/23, 20:41
-
Christian Kuhn merged patch set 3 11/21/23, 20:41
-
Andreas Kienast commented on patch set 3 11/24/23, 08:16
Post -1: This forces me now to press <TAB> twice in the backend login to switch from the username field to the password field? Is this really intended? -
Patrick Schriner commented on patch set 3 11/24/23, 08:36
Reply Unresolved
I definitely get your point but miss a good solution. https://ec.europa.eu/social/main.jsp?catId=1202&intPageId=5581&langId=en e.g. will have impact on how far we have to go regarding accessibility. -
Frank Nägler commented on patch set 3 11/24/23, 08:54
Also, a post -1 from my side. It is not only the login form. All fields in the form engine are affected by this change. Every field containing a clearable icon now requires a double tab to jump into the following field. From an editor's perspective, this change makes editing content more annoying. I know about the importance of accessibility, but we can't make the daily work for editors worse. Concrete to this change: I see no benefit regarding accessibility. The target person (people who only use a keyboard) can delete the content of a field with the keyboard. No need for them to use the clearable icon at all. -
Patrick Schriner commented on patch set 3 11/24/23, 09:31
Reply Unresolved
By that logic someone who's not restricted to using the keyboard doesn't need this feature either (the X to use by mouse) I'd love to have input by an ARIA expert. This patch was based on feedback by a (partially) disabled person using the TYPO3 backend. And, tbh, following someone on the TYPO3 backend has been eye opening for me. -
Andreas Kienast wrote 11/24/23, 09:34
Created a revert of this change as I58acdd89a61f3df258e755c893389fe960985b8f