Review main Merged

81746[BUGFIX] Ensure title is set for ElementBrowser

Oli Bartsch CR +2 V +2 Normal +78 −2 updated 11/18/23, 00:31

Commit message

FieldControl is required to set a title.
To ensure this, the field control options
can now be used to set a custom title.

Additionally, a fallback is added to ensure
a title is always set, even if a custom
TCA type is used and no title is defined,
using the FieldControl option.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 68

  1. Oli Bartsch uploaded patch set 1 11/15/23, 07:33

  2. core-ci voted on patch set 1 V +1 11/15/23, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48940

  3. Benni Mack updated the commit message in patch set 2 V +1 11/15/23, 10:07

  4. core-ci voted on patch set 2 V +1 11/15/23, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48946

  5. Benni Mack voted on patch set 2 V +1 CR +1 11/17/23, 17:11

  6. Jochen Roth voted on patch set 2 V +1 CR +1 11/17/23, 18:42

  7. Oli Bartsch voted on patch set 2 V +2 CR +2 11/18/23, 00:31

  8. Oli Bartsch merged patch set 3 11/18/23, 00:31