81748Revert "[TASK] Use ConsumableNonce instead of blunt Nonce in CSP context"
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 29
- typo3/sysext/adminpanel/Classes/Controller/MainController.php+2 −2
- typo3/sysext/adminpanel/Classes/Modules/Debug/Events.php+1 −1
- typo3/sysext/adminpanel/Classes/Utility/HtmlDumper.php+3 −4
- typo3/sysext/adminpanel/Classes/Utility/ResourceUtility.php+4 −5
- typo3/sysext/backend/Classes/Middleware/ContentSecurityPolicyHeaders.php+2 −1
- typo3/sysext/core/Classes/Core/RequestId.php+3 −3
- typo3/sysext/core/Classes/Domain/ConsumableString.php+1 −1
- typo3/sysext/core/Classes/Http/Security/ReferrerEnforcer.php+2 −2
- typo3/sysext/core/Classes/Page/AssetRenderer.php+6 −6
- typo3/sysext/core/Classes/Page/ImportMap.php+2 −2
- typo3/sysext/core/Classes/Page/JavaScriptRenderer.php+3 −3
- typo3/sysext/core/Classes/Page/PageRenderer.php+5 −5
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/ConsumableNonce.phpdeleted+0 −41
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/ModelService.php+8 −4
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/Policy.php+3 −2
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/SourceKeyword.php+5 −1
- typo3/sysext/core/Classes/Utility/DebugUtility.php+6 −0
- typo3/sysext/core/Tests/Functional/Security/ContentSecurityPolicy/PolicyTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Http/Security/ReferrerEnforcerTest.php+6 −5
- typo3/sysext/core/Tests/Unit/Page/ImportMapTest.php+10 −10
Show 9 more files
- typo3/sysext/core/Tests/Unit/Page/PageRendererTest.php+2 −2
- typo3/sysext/extbase/Classes/Utility/DebuggerUtility.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Security/NonceViewHelper.php+1 −1
- typo3/sysext/frontend/Classes/Html/HtmlWorker.php+3 −4
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+3 −3
- typo3/sysext/frontend/Classes/Middleware/ContentSecurityPolicyHeaders.php+2 −1
- typo3/sysext/install/Classes/Controller/InstallerController.php+3 −3
- typo3/sysext/install/Classes/Controller/LayoutController.php+3 −3
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/ContentSecurityPolicyMutationsProvider.php+2 −2
Review log 510
-
Christian Kuhn uploaded patch set 1 11/15/23, 11:24
-
core-ci voted on patch set 1 V +1 11/15/23, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48949
-
Christian Kuhn updated the commit message in patch set 2
V +111/15/23, 11:31 -
Christian Kuhn updated the commit message in patch set 3 11/15/23, 11:31
-
Christian Kuhn updated the commit message in patch set 4 11/15/23, 11:31
-
core-ci voted on patch set 2 V +1 11/15/23, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48950
-
core-ci voted on patch set 3 V -1 11/15/23, 11:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48951
-
core-ci voted on patch set 4 V +1 11/15/23, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48952
-
core-ci voted on patch set 3 V -1 11/15/23, 11:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48951
-
Christian Kuhn abandoned the change 11/15/23, 11:58