Review main Abandoned

81752[BUGFIX] Only render infobox for custom search if search word was used

Marcin Sągol CR 0 V 0 Easy +10 −8 updated 01/03/24, 13:20

Commit message

This commit fixes a bug where an infobox was rendered for
the `CustomSearch` view of the `Search` action in
the DatabaseIntegrityController, even if the search word
was not set at all.

We can set a search word when the raw search mode is used,
and then the search includes all configured fields,
not just some selected ones.
The other mode is query, where we can use the UI to build
more complex queries.

With these changes, we check if the search word was set,
and only then try to render search results or an infobox,
with information that there were no records found for
the given search word.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 811

  1. Marcin Sągol uploaded patch set 1 11/15/23, 21:34

  2. Marcin Sągol updated the commit message in patch set 2 11/15/23, 21:36

  3. core-ci voted on patch set 1 V +1 11/15/23, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48990

  4. core-ci voted on patch set 2 V +1 11/15/23, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48991

  5. Markus Klein updated the commit message in patch set 3 V +1 11/16/23, 16:50

  6. Markus Klein voted on patch set 3 CR +1 11/16/23, 16:50

  7. core-ci voted on patch set 3 V +1 11/16/23, 16:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49038

  8. Oli Bartsch commented on patch set 3 11/17/23, 12:01

    Hi, just saw your patch. Your might want to have a look at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81764 where I did a general clean up of this functionality. This might also resolve your issue.
  9. Riccardo De Contardi commented on patch set 3 11/25/23, 10:53

    I confirm that this issue is already solved with https://review.typo3.org/c/Packages/TYPO3.CMS/+/81764
  10. Oli Bartsch abandoned the change 01/03/24, 13:17

    As mentioned and confirmed by Riccardo, this has already been resolved with https://review.typo3.org/c/Packages/TYPO3.CMS/+/81764 .
  11. Oli Bartsch commented on patch set 3 01/03/24, 13:20

    Reply

    Hi Marcin, thank you for your contribution, I really appreciate your work in this area. However, I've abandoned this patch now, due to the given reason.