Review main Merged

81754[BUGFIX] Avoid 1s client-side backend request caching

Benjamin Franzke CR +2 V +2 Easy +5 −8 updated 11/16/23, 10:44

Commit message

Backend responses must never be cached. The previously used
Cache-Control instruction "must-revalidate" implicitly enabled
caching in order to possibly reuse a response. While that
could only happen when two requests to the same URL are
invoked within one second (because the browsers
`If-Modified-Since` header and our `Last-Modified` header
match, causing the webserver to issue a 304 response),
that is certainly possible in CI setups or fast user clicks.

Use `no-store` in order to instruct browsers to not cache
and try revalidation at all.

Also remove hard-coded acceptance test waiters that
were introduced to circumvent this (but only did sometimes
because with 0.5s wait time there was still room for
two requests within one second).

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1521

  1. Benjamin Franzke uploaded patch set 1 11/15/23, 22:12

  2. Benjamin Franzke uploaded patch set 2 11/15/23, 22:17

  3. Benjamin Franzke uploaded patch set 3 11/15/23, 22:20

  4. core-ci voted on patch set 1 V -1 11/15/23, 22:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48996

  5. core-ci voted on patch set 2 V +1 11/15/23, 22:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48997

  6. core-ci voted on patch set 3 V +1 11/15/23, 22:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48998

  7. Benjamin Franzke uploaded patch set 4 V +1 11/16/23, 05:54

  8. core-ci voted on patch set 4 V +1 11/16/23, 06:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49002

  9. Benjamin Franzke uploaded patch set 5 V +1 11/16/23, 06:10

  10. core-ci voted on patch set 5 V +1 11/16/23, 06:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49003

  11. Andreas Kienast commented on patch set 5 CR +1 11/16/23, 08:32

    Jesus Christ...
  12. Andreas Kienast voted on patch set 5 V +1 11/16/23, 08:49

  13. Christian Kuhn voted on patch set 5 V +1 CR +1 11/16/23, 09:39

  14. Christian Kuhn commented on patch set 5 11/16/23, 09:40

    Impressive! Thank you so much!
  15. Andreas Kienast rebased onto patch set 6 CR +1 V +1 11/16/23, 09:46

  16. Andreas Kienast commented on patch set 6 V +1 CR +1 11/16/23, 09:47

    Rebased on current HEAD to avoid potential side-effects when merging
  17. Christian Kuhn voted on patch set 6 V +1 CR +1 11/16/23, 09:51

  18. Benjamin Franzke voted on patch set 6 V +2 CR +2 11/16/23, 09:54

  19. core-ci voted on patch set 6 V +1 11/16/23, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49009

  20. Benjamin Franzke merged patch set 7 11/16/23, 10:12

  21. Oliver Hader voted on patch set 7 CR +1 11/16/23, 10:44