Review 11.5 Merged

81756[BUGFIX] Avoid 1s client-side backend request caching

Benjamin Franzke CR +2 V +2 Easy +5 −5 updated 11/16/23, 10:12

Commit message

Backend responses must never be cached. The previously used
Cache-Control instruction "must-revalidate" implicitly enabled
caching in order to possibly reuse a response. While that
could only happen when two requests to the same URL are
invoked within one second (because the browsers
`If-Modified-Since` header and our `Last-Modified` header
match, causing the webserver to issue a 304 response),
that is certainly possible in CI setups or fast user clicks.

Use `no-store` in order to instruct browsers to not cache
and try revalidation at all.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 57

  1. Benjamin Franzke uploaded patch set 1 11/16/23, 09:54

  2. Benjamin Franzke voted on patch set 1 V +2 CR +2 11/16/23, 09:55

  3. core-ci voted on patch set 1 V -1 11/16/23, 10:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49010

  4. Benjamin Franzke rebased onto patch set 2 CR +2 V +2 11/16/23, 10:03

  5. core-ci voted on patch set 2 V +1 11/16/23, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49012

  6. Benjamin Franzke voted on patch set 2 V +2 CR +2 11/16/23, 10:11

  7. Benjamin Franzke merged patch set 3 11/16/23, 10:12