Review main Merged

81768[TASK] Use strict types everywhere in ext:beuser

Torben Hansen CR +2 V +2 Easy +10 −34 updated 11/18/23, 16:12

Commit message

This change add missing type declarations for all function
arguments and ensures, that every function has a proper return
type. Additionally, `@param` doc comments have been removed
for function arguments having a native PHP type declaration.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Chris Müller +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 56

  1. Torben Hansen uploaded patch set 1 11/18/23, 12:20

  2. core-ci voted on patch set 1 V +1 11/18/23, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49083

  3. Chris Müller voted on patch set 1 CR +1 11/18/23, 12:51

  4. Simon Schaufelberger voted on patch set 1 V +1 CR +1 11/18/23, 15:40

  5. Nikita Hovratov voted on patch set 1 V +2 CR +2 11/18/23, 16:12

  6. Nikita Hovratov merged patch set 2 11/18/23, 16:12