Review 12.4 Merged

81790[BUGFIX] Restore diff-item-result-inline styling

Jasmina Ließmann CR +2 V +2 Easy +8 −3 updated 11/22/23, 10:29

Commit message

With the recent introduction of formatted FlexForm diff views, the
styling for "diff-item-result-inline" was removed. However, it is still
needed in other areas. For example in the active TypoScript view when
displaying substitution of constant values.

This patch adds the styling for "diff-item-result-inline" back and in
exchange removes this class from the workspaces "view changes" and
"history" views. There it is not needed, and preserving white-space is
even advantageous.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • core-ci +1 CI

Issues 2

Files 4

Review log 57

  1. Jasmina Ließmann commented on patch set 1 11/22/23, 09:50

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js
  2. core-ci voted on patch set 1 V -1 11/22/23, 09:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49326

  3. Andreas Kienast uploaded patch set 2 V -1 11/22/23, 10:12

  4. Andreas Kienast marked it ready for review 11/22/23, 10:12

  5. core-ci voted on patch set 2 V +1 11/22/23, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49330

  6. Jasmina Ließmann voted on patch set 2 V +2 CR +2 11/22/23, 10:29

  7. Jasmina Ließmann merged patch set 3 11/22/23, 10:29