Review main Merged

81795[BUGFIX] Properly handle aliases with the AsCommand registration

Oli Bartsch CR +2 V +2 Normal +91 −6 updated 11/20/23, 12:32

Commit message

The auto configuration of the symfony AsCommand
attribute, introduced with  #101567, now properly
handles the `aliases` parameter.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 67

  1. Oli Bartsch uploaded patch set 1 11/20/23, 09:44

  2. Benjamin Franzke voted on patch set 1 CR +1 11/20/23, 09:46

  3. core-ci voted on patch set 1 V +1 11/20/23, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49121

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 11/20/23, 09:56

  5. Garvin Hicking commented on patch set 1 V +1 CR +1 11/20/23, 10:03

    Seems to work, nice catch on supporting this! (and yields an error when trying to pass a string as alias (instead of array) :)
  6. Benjamin Franzke voted on patch set 1 V +2 CR +2 11/20/23, 10:29

  7. Benjamin Franzke merged patch set 2 11/20/23, 12:32