Review main Merged Breaking

81799[!!!][TASK] Merge EXT:t3editor into backend

Andreas Kienast CR +2 V +2 Expert +600 −1437 updated 11/25/23, 16:06

Commit message

This patch merges the "t3editor" extension into EXT:backend. The
overall benefit is a globally available syntax highlighting at various
places, without the need to have an extra extension installed.

Another benefit it the removal of installation checks of EXT:t3editor
and fallbacks if the "soft requirement" is not fulfilled, reducing
soft-cross-dependencies.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 147

Show 127 more files

Review log 4267

Show 2442 earlier messages
  1. Andreas Kienast uploaded patch set 1 11/20/23, 14:50

  2. core-ci voted on patch set 1 V -1 11/20/23, 14:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49135

  3. Andreas Kienast uploaded patch set 2 V -1 11/20/23, 14:59

  4. Andreas Kienast uploaded patch set 3 11/20/23, 14:59

  5. core-ci voted on patch set 2 V -1 11/20/23, 15:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49138

  6. core-ci voted on patch set 3 V -1 11/20/23, 15:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49139

  7. Andreas Kienast uploaded patch set 4 V -1 11/20/23, 15:25

  8. core-ci voted on patch set 4 V -1 11/20/23, 15:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49147

  9. core-ci commented on patch set 4 11/20/23, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49147

  10. Andreas Kienast uploaded patch set 5 V -1 11/21/23, 08:34

  11. core-ci voted on patch set 5 V -1 11/21/23, 08:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49196

  12. core-ci commented on patch set 5 11/21/23, 11:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49196

  13. Andreas Kienast uploaded patch set 6 V -1 11/21/23, 12:25

  14. core-ci voted on patch set 6 V -1 11/21/23, 12:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49222

  15. Andreas Kienast uploaded patch set 7 V -1 11/21/23, 13:54

  16. core-ci voted on patch set 7 V +1 11/21/23, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49231

  17. Andreas Kienast uploaded patch set 8 V +1 11/21/23, 16:25

  18. core-ci voted on patch set 8 V +1 11/21/23, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49261

  19. Andreas Kienast uploaded patch set 9 V +1 11/21/23, 16:33

  20. core-ci voted on patch set 9 V +1 11/21/23, 16:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49262

  21. Andreas Kienast uploaded patch set 10 V +1 11/22/23, 08:08

  22. core-ci voted on patch set 10 V +1 11/22/23, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49316

  23. Chris Müller commented on patch set 10 11/22/23, 08:20

    composer.json:33

    Please list typo3/cms-t3editor also in the replace section.
  24. Andreas Kienast commented on patch set 10 CR -1 11/22/23, 08:38

    composer.json:33 Reply

    Will push another patch set with a stub t3editor extension.
  25. Andreas Kienast uploaded patch set 11 CR -1 V +1 11/22/23, 08:39

  26. Andreas Kienast uploaded patch set 12 11/22/23, 08:41

  27. Andreas Kienast uploaded patch set 13 11/22/23, 08:42

  28. Andreas Kienast uploaded patch set 14 11/22/23, 08:46

  29. core-ci voted on patch set 12 V +1 11/22/23, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49319

  30. core-ci voted on patch set 11 V -1 11/22/23, 08:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49318

  31. core-ci voted on patch set 13 V +1 11/22/23, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49320

  32. core-ci voted on patch set 14 V +1 11/22/23, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49321

  33. Jasmina Ließmann voted on patch set 14 V +1 11/22/23, 09:14

  34. Oli Bartsch commented on patch set 14 11/22/23, 09:40

    NodeFactory.php:93

    I suggest to also rename the node, preventing further confusion.

    AjaxRoutes.php:406

    I suggest to change the keys as well as the path, making use of the alias feature.

    tt_content.php:5

    codeEditor

    Breaking-102440-EXTt3editorMergedIntoEXTbackend.rst:28

    By default, this ...
  35. Oli Bartsch uploaded patch set 15 V +1 11/22/23, 09:41

  36. Oli Bartsch commented on patch set 15 11/22/23, 09:42

    tt_content.php:5 Reply

    Done
  37. core-ci voted on patch set 15 V +1 11/22/23, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49324

  38. Andreas Kienast uploaded patch set 16 V +1 11/22/23, 10:58

  39. Andreas Kienast uploaded patch set 17 11/22/23, 11:03

  40. Andreas Kienast commented on patch set 17 11/22/23, 11:04

    NodeFactory.php:93 Reply

    Done

    AjaxRoutes.php:406 Reply

    Done

    Breaking-102440-EXTt3editorMergedIntoEXTbackend.rst:28 Reply

    Done
  41. Andreas Kienast commented on patch set 17 11/22/23, 11:04

    composer.json:33 Reply

    Done
  42. core-ci voted on patch set 16 V -1 11/22/23, 11:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49336

  1. core-ci voted on patch set 17 V -1 11/22/23, 11:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49337

  2. Andreas Kienast uploaded patch set 18 V -1 11/22/23, 11:13

  3. core-ci voted on patch set 18 V +1 11/22/23, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49338

  4. Andreas Kienast voted on patch set 18 CR -2 11/22/23, 16:59

  5. Andreas Kienast uploaded patch set 19 V +1 11/22/23, 17:23

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  6. core-ci voted on patch set 19 V +1 11/22/23, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49405

  7. Andreas Kienast uploaded patch set 20 V +1 11/24/23, 11:52

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  8. Andreas Kienast voted on patch set 20 CR 0 11/24/23, 11:53

  9. Christian Kuhn commented on patch set 20 CR -1 11/24/23, 11:59

    on it.
  10. core-ci voted on patch set 20 V -1 11/24/23, 12:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49888

  11. Andreas Kienast uploaded patch set 21 CR -1 V -1 11/24/23, 12:41

  12. core-ci voted on patch set 21 V +1 11/24/23, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49891

  13. Christian Kuhn voted on patch set 20 CR +1 11/24/23, 12:47

  14. Christian Kuhn voted on patch set 21 CR +1 11/24/23, 12:47

  15. Christian Kuhn commented on patch set 21 V +1 11/24/23, 15:12

    when you grep for 't3editor', a couple of them still pop up: some matches especially in ext:backend - relavant ones are mostly comments and a .xlf files. a minor new patch set to clean this up would be good, but it's not mission critical. i've read the patch and tested BE: fine. i'll vote up now and let andy decide if he pushes a minor change again.
  16. Andreas Kienast commented on patch set 21 CR -1 11/25/23, 13:48

    on it. Along with the suggested changes, I'll push a cleanup in the locallang file.
  17. Andreas Kienast uploaded patch set 22 CR +1 V +1 11/25/23, 13:52

  18. core-ci voted on patch set 22 V -1 11/25/23, 14:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49927

  19. Andreas Kienast uploaded patch set 23 V -1 11/25/23, 14:36

  20. core-ci voted on patch set 23 V +1 11/25/23, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49930

  21. Christian Kuhn voted on patch set 23 CR +1 V +1 11/25/23, 14:43

  22. Stefan Bürk voted on patch set 23 CR +2 V +2 11/25/23, 15:14

  23. Stefan Bürk merged patch set 24 11/25/23, 15:16

  24. Stefan Bürk commented on patch set 24 11/25/23, 15:32

    Merged for now - but I think we should consider if we need to add a composer classalias map for the now moved classes (controllers).
  25. Andreas Kienast commented on patch set 24 11/25/23, 16:06

    Reply

    Thanks for merging. I don‘t think we need a class alias map, basically the whole extension was internal.