81799[!!!][TASK] Merge EXT:t3editor into backend
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 147
- Build/Sources/TypeScript/backend/code-editor/autocomplete/completion-result.tsrenamed+2 −2
- Build/Sources/TypeScript/backend/code-editor/autocomplete/ts-code-completion.tsrenamed+6 −6
- Build/Sources/TypeScript/backend/code-editor/autocomplete/ts-parser.tsrenamed+3 −3
- Build/Sources/TypeScript/backend/code-editor/autocomplete/ts-ref.tsrenamed+1 −1
- Build/Sources/TypeScript/backend/code-editor/element/code-mirror-element.tsrenamed+23 −1
- Build/Sources/TypeScript/backend/code-editor/language/typoscript.tsrenamed+3 −3
- Build/Sources/TypeScript/backend/code-editor/stream-parser/typoscript.tsrenamed+0 −0
- Build/Sources/TypeScript/backend/pagetsconfig/pagetsconfig-includes.ts+2 −2
- Build/Sources/TypeScript/backend/grid-editor.ts+1 −1
- Build/Sources/TypeScript/tstemplate/template-analyzer.ts+2 −2
- Build/Gruntfile.js+35 −27
- Build/tsconfig.json+0 −3
- Build/web-test-runner.config.mjs+40 −40
- typo3/sysext/adminpanel/Documentation/Settings.cfg+0 −1
- typo3/sysext/backend/Classes/CodeEditor/Exception/InvalidModeException.phprenamed+1 −1
- typo3/sysext/backend/Classes/CodeEditor/Registry/AddonRegistry.phprenamed+4 −4
- typo3/sysext/backend/Classes/CodeEditor/Registry/ModeRegistry.phprenamed+9 −12
- typo3/sysext/backend/Classes/CodeEditor/Addon.phprenamed+1 −1
- typo3/sysext/backend/Classes/CodeEditor/CodeEditor.phprenamed+10 −13
- typo3/sysext/backend/Classes/CodeEditor/Mode.phprenamed+1 −1
Show 127 more files
- typo3/sysext/backend/Classes/Controller/CodeEditor/CodeCompletionController.phprenamed+7 −8
- typo3/sysext/backend/Classes/Controller/CodeEditor/TypoScriptReferenceController.phprenamed+2 −2
- typo3/sysext/backend/Classes/EventListener/InitializeCodeEditorInEditFileForm.phprenamed+10 −10
- typo3/sysext/backend/Classes/Form/Element/BackendLayoutWizardElement.php+8 −13
- typo3/sysext/backend/Classes/Form/Element/CodeEditorElement.phprenamed+17 −24
- typo3/sysext/backend/Classes/Form/Element/JsonElement.php+7 −9
- typo3/sysext/backend/Classes/Form/NodeFactory.php2+1 −2
- typo3/sysext/backend/Configuration/Backend/T3editor/Addons.phprenamed+1 −1
- typo3/sysext/backend/Configuration/Backend/T3editor/Modes.phprenamed+2 −2
- typo3/sysext/backend/Configuration/Backend/AjaxRoutes.php2+12 −0
- typo3/sysext/backend/Configuration/TCA/Overrides/be_groups.phprenamed+2 −2
- typo3/sysext/backend/Configuration/TCA/Overrides/be_users.phprenamed+2 −2
- typo3/sysext/backend/Configuration/TCA/Overrides/pages.phprenamed+2 −2
- typo3/sysext/backend/Configuration/TCA/Overrides/sys_template.phprenamed+4 −4
- typo3/sysext/backend/Configuration/TCA/Overrides/tt_content.php2new+19 −0
- typo3/sysext/backend/Configuration/JavaScriptModules.php+43 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_codeeditor.xlfnew+14 −0
- typo3/sysext/backend/Resources/Private/tsref.xmlrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/code-editor/autocomplete/completion-result.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/code-editor/autocomplete/ts-code-completion.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/code-editor/autocomplete/ts-parser.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/code-editor/autocomplete/ts-ref.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/code-editor/element/code-mirror-element.jsrenamed+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/code-editor/language/typoscript.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/code-editor/stream-parser/typoscript.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/@codemirror/autocomplete.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/@codemirror/commands.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/@codemirror/lang-css.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/@codemirror/lang-html.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/@codemirror/lang-javascript.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/@codemirror/lang-json.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/@codemirror/lang-php.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/@codemirror/lang-sql.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/@codemirror/lang-xml.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/@codemirror/language.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/@codemirror/lint.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/@codemirror/search.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/@codemirror/state.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/@codemirror/theme-one-dark.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/@codemirror/view.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/@lezer/common.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/@lezer/css.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/@lezer/highlight.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/@lezer/html.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/@lezer/javascript.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/@lezer/json.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/@lezer/lr.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/@lezer/php.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/@lezer/xml.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/crelt.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/style-mod.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/w3c-keyname.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/pagetsconfig/pagetsconfig-includes.js+2 −2
- typo3/sysext/backend/Tests/Unit/CodeEditor/Registry/AddonRegistryTest.phprenamed+3 −3
- typo3/sysext/backend/Tests/Unit/CodeEditor/Registry/ModeRegistryTest.phprenamed+3 −3
- typo3/sysext/backend/Tests/Unit/Form/Element/JsonElementTest.php+3 −3
- typo3/sysext/backend/composer.json3+2 −0
- typo3/sysext/core/Classes/Configuration/Tca/TcaMigration.php+30 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102440-EXTt3editorMergedIntoEXTbackend.rst2new+59 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Deprecation-102440-EXTt3editorMergedIntoEXTBackend.rstnew+45 −0
- typo3/sysext/core/Documentation/Settings.cfg+0 −1
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileOperationsCest.php+5 −4
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/UsersCest.php+11 −2
- typo3/sysext/core/Tests/Acceptance/Application/Template/TemplateCest.php+4 −4
- typo3/sysext/core/Tests/Functional/Package/PackageStatesTest.php+0 −2
- typo3/sysext/core/Tests/Unit/Configuration/Tca/TcaMigrationTest.php+64 −0
- typo3/sysext/dashboard/Documentation/Settings.cfg+0 −1
- typo3/sysext/extensionmanager/Classes/Controller/ExtensionComposerStatusController.php+15 −23
- typo3/sysext/felogin/Documentation/Settings.cfg+0 −1
- typo3/sysext/fluid_styled_content/Documentation/Settings.cfg+0 −1
- typo3/sysext/form/Documentation/Settings.cfg+0 −1
- typo3/sysext/impexp/Documentation/Settings.cfg+0 −1
- typo3/sysext/indexed_search/Documentation/Settings.cfg+0 −1
- typo3/sysext/linkvalidator/Documentation/Settings.cfg+0 −1
- typo3/sysext/lowlevel/Documentation/Settings.cfg+0 −1
- typo3/sysext/reactions/Documentation/Settings.cfg+0 −1
- typo3/sysext/recycler/Documentation/Settings.cfg+0 −1
- typo3/sysext/redirects/Documentation/Settings.cfg+0 −1
- typo3/sysext/reports/Documentation/Settings.cfg+0 −1
- typo3/sysext/rte_ckeditor/Documentation/Settings.cfg+0 −1
- typo3/sysext/scheduler/Documentation/Settings.cfg+0 −1
- typo3/sysext/seo/Documentation/Settings.cfg+0 −1
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeTextFormatCodeEditor.phprenamed+2 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGeneratorResolver.php+1 −1
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_t3editor.php+4 −4
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_t3editor_flex_1_inline_1_child.php+1 −1
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_t3editor_inline_1_child.php+1 −1
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_inline_1n_inline_2_child.php+1 −1
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_inline_expand_inline_1_child.php+1 −1
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_l10nreadonly.php+1 −1
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_type.php+1 −1
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_typeforeign.php+1 −1
- typo3/sysext/t3editor/Configuration/Backend/AjaxRoutes.phpdeleted+0 −18
- typo3/sysext/t3editor/Configuration/TCA/Overrides/tt_content.phpdeleted+0 −19
- typo3/sysext/t3editor/Configuration/JavaScriptModules.phpdeleted+0 −57
- typo3/sysext/t3editor/Configuration/Services.yamldeleted+0 −8
- typo3/sysext/t3editor/Documentation/CodeSnippets/Automatic/T3editor1.rst.txtdeleted+0 −23
- typo3/sysext/t3editor/Documentation/Developer/Extend.rstdeleted+0 −137
- typo3/sysext/t3editor/Documentation/Developer/Index.rstdeleted+0 −14
- typo3/sysext/t3editor/Documentation/Developer/TCA.rstdeleted+0 −37
- typo3/sysext/t3editor/Documentation/Images/AutomaticScreenshots/T3editor1.pngdeletedbinary
- typo3/sysext/t3editor/Documentation/Images/AutomaticScreenshots/T3editor1.rst.txtdeleted+0 −9
- typo3/sysext/t3editor/Documentation/Installation/Index.rstdeleted+0 −59
- typo3/sysext/t3editor/Documentation/Introduction/Index.rstdeleted+0 −27
- typo3/sysext/t3editor/Documentation/genindex.rstdeleted+0 −7
- typo3/sysext/t3editor/Documentation/Includes.rst.txtdeleted+0 −34
- typo3/sysext/t3editor/Documentation/Index.rstdeleted+0 −54
- typo3/sysext/t3editor/Documentation/screenshots.jsondeleted+0 −49
- typo3/sysext/t3editor/Documentation/Settings.cfgdeleted+0 −66
- typo3/sysext/t3editor/Documentation/Sitemap.rstdeleted+0 −9
- typo3/sysext/t3editor/Resources/Private/Language/locallang.xlfdeleted+0 −47
- typo3/sysext/t3editor/Resources/Public/Icons/Extension.pngdeletedbinary
- typo3/sysext/t3editor/Resources/Public/JavaScript/autocomplete/ts-code-completion.jsdeleted+0 −13
- typo3/sysext/t3editor/Resources/Public/JavaScript/autocomplete/ts-ref.jsdeleted+0 −13
- typo3/sysext/t3editor/Resources/Public/JavaScript/language/typoscript.jsdeleted+0 −13
- typo3/sysext/t3editor/.gitattributesdeleted+0 −2
- typo3/sysext/t3editor/composer.jsondeleted+0 −44
- typo3/sysext/t3editor/ext_emconf.phpdeleted+0 −19
- typo3/sysext/t3editor/ext_localconf.phpdeleted+0 −14
- typo3/sysext/t3editor/LICENSE.txtdeleted+0 −339
- typo3/sysext/t3editor/README.rstdeleted+0 −13
- typo3/sysext/tstemplate/Configuration/JavaScriptModules.php+0 −1
- typo3/sysext/tstemplate/Resources/Public/JavaScript/template-analyzer.js+2 −2
- typo3/sysext/workspaces/Documentation/Settings.cfg+0 −1
- .gitattributes+0 −3
- composer.json+0 −3
- composer.lock+1 −1
Review log 4267
Show 2442 earlier messages
-
Andreas Kienast uploaded patch set 1 11/20/23, 14:50
-
core-ci voted on patch set 1 V -1 11/20/23, 14:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49135
-
Andreas Kienast uploaded patch set 2
V -111/20/23, 14:59 -
Andreas Kienast uploaded patch set 3 11/20/23, 14:59
-
core-ci voted on patch set 2 V -1 11/20/23, 15:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49138
-
core-ci voted on patch set 3 V -1 11/20/23, 15:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49139
-
Andreas Kienast uploaded patch set 4
V -111/20/23, 15:25 -
core-ci voted on patch set 4 V -1 11/20/23, 15:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49147
-
core-ci commented on patch set 4 11/20/23, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49147
-
Andreas Kienast uploaded patch set 5
V -111/21/23, 08:34 -
core-ci voted on patch set 5 V -1 11/21/23, 08:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49196
-
core-ci commented on patch set 5 11/21/23, 11:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49196
-
Andreas Kienast uploaded patch set 6
V -111/21/23, 12:25 -
core-ci voted on patch set 6 V -1 11/21/23, 12:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49222
-
Andreas Kienast uploaded patch set 7
V -111/21/23, 13:54 -
core-ci voted on patch set 7 V +1 11/21/23, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49231
-
Andreas Kienast uploaded patch set 8
V +111/21/23, 16:25 -
core-ci voted on patch set 8 V +1 11/21/23, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49261
-
Andreas Kienast uploaded patch set 9
V +111/21/23, 16:33 -
core-ci voted on patch set 9 V +1 11/21/23, 16:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49262
-
Andreas Kienast uploaded patch set 10
V +111/22/23, 08:08 -
core-ci voted on patch set 10 V +1 11/22/23, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49316
-
Chris Müller commented on patch set 10 11/22/23, 08:20
-
Andreas Kienast commented on patch set 10 CR -1 11/22/23, 08:38
composer.json:33ReplyWill push another patch set with a stub t3editor extension. -
Andreas Kienast uploaded patch set 11
CR -1V +111/22/23, 08:39 -
Andreas Kienast uploaded patch set 12 11/22/23, 08:41
-
Andreas Kienast uploaded patch set 13 11/22/23, 08:42
-
Andreas Kienast uploaded patch set 14 11/22/23, 08:46
-
core-ci voted on patch set 12 V +1 11/22/23, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49319
-
core-ci voted on patch set 11 V -1 11/22/23, 08:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49318
-
core-ci voted on patch set 13 V +1 11/22/23, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49320
-
core-ci voted on patch set 14 V +1 11/22/23, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49321
-
Jasmina Ließmann voted on patch set 14 V +1 11/22/23, 09:14
-
Oli Bartsch commented on patch set 14 11/22/23, 09:40
NodeFactory.php:93I suggest to also rename the node, preventing further confusion.AjaxRoutes.php:406I suggest to change the keys as well as the path, making use of the alias feature.tt_content.php:5codeEditorBreaking-102440-EXTt3editorMergedIntoEXTbackend.rst:28By default, this ... -
Oli Bartsch uploaded patch set 15
V +111/22/23, 09:41 -
Oli Bartsch commented on patch set 15 11/22/23, 09:42
tt_content.php:5ReplyDone -
core-ci voted on patch set 15 V +1 11/22/23, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49324
-
Andreas Kienast uploaded patch set 16
V +111/22/23, 10:58 -
Andreas Kienast uploaded patch set 17 11/22/23, 11:03
-
Andreas Kienast commented on patch set 17 11/22/23, 11:04
NodeFactory.php:93ReplyDoneAjaxRoutes.php:406ReplyDoneBreaking-102440-EXTt3editorMergedIntoEXTbackend.rst:28ReplyDone -
Andreas Kienast commented on patch set 17 11/22/23, 11:04
composer.json:33ReplyDone -
core-ci voted on patch set 16 V -1 11/22/23, 11:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49336
-
core-ci voted on patch set 17 V -1 11/22/23, 11:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49337
-
Andreas Kienast uploaded patch set 18
V -111/22/23, 11:13 -
core-ci voted on patch set 18 V +1 11/22/23, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49338
-
Andreas Kienast voted on patch set 18 CR -2 11/22/23, 16:59
-
Andreas Kienast uploaded patch set 19
V +111/22/23, 17:23Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 19 V +1 11/22/23, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49405
-
Andreas Kienast uploaded patch set 20
V +111/24/23, 11:52Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Andreas Kienast voted on patch set 20 CR 0 11/24/23, 11:53
-
Christian Kuhn commented on patch set 20 CR -1 11/24/23, 11:59
on it. -
core-ci voted on patch set 20 V -1 11/24/23, 12:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49888
-
Andreas Kienast uploaded patch set 21
CR -1V -111/24/23, 12:41 -
core-ci voted on patch set 21 V +1 11/24/23, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49891
-
Christian Kuhn voted on patch set 20 CR +1 11/24/23, 12:47
-
Christian Kuhn voted on patch set 21 CR +1 11/24/23, 12:47
-
Christian Kuhn commented on patch set 21 V +1 11/24/23, 15:12
when you grep for 't3editor', a couple of them still pop up: some matches especially in ext:backend - relavant ones are mostly comments and a .xlf files. a minor new patch set to clean this up would be good, but it's not mission critical. i've read the patch and tested BE: fine. i'll vote up now and let andy decide if he pushes a minor change again. -
Andreas Kienast commented on patch set 21 CR -1 11/25/23, 13:48
on it. Along with the suggested changes, I'll push a cleanup in the locallang file. -
Andreas Kienast uploaded patch set 22
CR +1V +111/25/23, 13:52 -
core-ci voted on patch set 22 V -1 11/25/23, 14:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49927
-
Andreas Kienast uploaded patch set 23
V -111/25/23, 14:36 -
core-ci voted on patch set 23 V +1 11/25/23, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49930
-
Christian Kuhn voted on patch set 23 CR +1 V +1 11/25/23, 14:43
-
Stefan Bürk voted on patch set 23 CR +2 V +2 11/25/23, 15:14
-
Stefan Bürk merged patch set 24 11/25/23, 15:16
-
Stefan Bürk commented on patch set 24 11/25/23, 15:32
Merged for now - but I think we should consider if we need to add a composer classalias map for the now moved classes (controllers). -
Andreas Kienast commented on patch set 24 11/25/23, 16:06
Reply
Thanks for merging. I don‘t think we need a class alias map, basically the whole extension was internal.
composer.json:33