Review main Merged

81804[TASK] Avoid deprecated doctrine `Type::getName()`

Stefan Bürk CR +2 V +2 Normal +43 −25 updated 11/20/23, 20:12

Commit message

The doctrine team deprecated the `Type::getName()` method
as it does not serve any purpose for doctrine anymore. [1]

This change modifies userland code to replace occurances
with `Type::getTypeRegistry()->lookupName($type)`.

[1] https://github.com/doctrine/dbal/blob/3.8.x/UPGRADE.md#deprecated-typegetname

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Andreas Nedbal +1
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Andreas Nedbal +1
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1015

  1. Stefan Bürk uploaded patch set 1 11/20/23, 16:10

  2. core-ci voted on patch set 1 V -1 11/20/23, 16:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49153

  3. Stefan Bürk uploaded patch set 2 V -1 11/20/23, 18:02

  4. Stefan Bürk rebased onto patch set 3 11/20/23, 18:02

  5. core-ci voted on patch set 2 V +1 11/20/23, 18:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49178

  6. core-ci voted on patch set 3 V +1 11/20/23, 18:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49179

  7. Stefan Bürk uploaded patch set 4 V +1 11/20/23, 18:11

  8. core-ci voted on patch set 4 V +1 11/20/23, 18:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49180

  9. Christian Kuhn updated the commit message in patch set 5 V +1 11/20/23, 19:00

  10. core-ci voted on patch set 5 V +1 11/20/23, 19:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49184

  11. Christian Kuhn voted on patch set 5 V +1 CR +1 11/20/23, 20:05

  12. Garvin Hicking voted on patch set 5 V +1 CR +1 11/20/23, 20:05

  13. Andreas Nedbal voted on patch set 5 V +1 CR +1 11/20/23, 20:08

  14. Stefan Bürk voted on patch set 5 V +2 CR +2 11/20/23, 20:12

  15. Stefan Bürk merged patch set 6 11/20/23, 20:12