Review main Merged Breaking

81812[!!!][TASK] Remove UserTSconfig option "overridePageModule"

Benni Mack CR +2 V +2 Normal +82 −30 updated 11/24/23, 11:50

Commit message

The UserTSconfig setting options.overridePageModule
was introduced in TYPO3 v4, to run TemplaVoila
and "regular" page module in parallel. However, this
feature was never rolled out completely throughout
the TYPO3 Backend, but only used in a few places,
and now it is only used in a few places (mainly workspaces).

Since TYPO3 v12, it is much easier to actually override
the page module through the Module API to replace
either the endpoint or to add a new module with an alias
to "web_layout", which should be used instead.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 914

  1. Benni Mack uploaded patch set 1 11/20/23, 22:30

  2. core-ci voted on patch set 1 V -1 11/20/23, 22:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49191

  3. Benni Mack uploaded patch set 2 V -1 11/24/23, 08:16

  4. Benni Mack uploaded patch set 3 11/24/23, 08:20

  5. core-ci voted on patch set 3 V +1 11/24/23, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49836

  6. Andreas Kienast voted on patch set 3 CR +1 V +1 11/24/23, 08:26

  7. core-ci voted on patch set 2 V -1 11/24/23, 08:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49835

  8. Benni Mack uploaded patch set 4 CR +1 V +1 11/24/23, 08:27

  9. Benni Mack uploaded patch set 5 11/24/23, 08:27

  10. core-ci voted on patch set 4 V +1 11/24/23, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49837

  11. core-ci voted on patch set 5 V +1 11/24/23, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49838

  12. Andreas Kienast voted on patch set 5 CR +1 V +1 11/24/23, 08:37

  13. Christian Kuhn voted on patch set 5 CR +2 V +2 11/24/23, 11:50

  14. Christian Kuhn merged patch set 6 11/24/23, 11:50