Review main Merged

81816[TASK] Modify handling of prefixed server version information

Stefan Bürk CR +2 V +2 Normal +62 −30 updated 11/21/23, 12:46

Commit message

Doctrine DBAL deprecated the `ServerInfoAwareConnection`
and `VersionAwarePlatformDriver` interfaces within `3.x`
and force all Driver and DriverConnection to implement
the APIs aware of the server version [1].

TYPO3 used the server version and prefixed them, which
will no longer work with the next Doctrine DBAL major
to due the call chain. The prefixed version has been
used in several places within the reporting module and
backend information to display database vendor aware
information.

This change adds a new `getPlatformServerVersion()`
method to the core connection class and removes the
prefixing from the `getServerVersion()` methods. All
usages in userland code are modified to use the new
method. Additionally, tests are aligned to this change.

[1] https://github.com/doctrine/dbal/blob/3.8.x/UPGRADE.md#deprecated-driver-level-apis-that-dont-take-the-server-version-into-account

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 810

  1. Stefan Bürk uploaded patch set 1 11/21/23, 11:43

  2. core-ci voted on patch set 1 V +1 11/21/23, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49216

  3. Stefan Bürk wrote 11/21/23, 11:59

    Topic set to doctrine-dbal
  4. Oliver Klee commented on patch set 1 V +1 CR +1 11/21/23, 12:27

    Checked that all usages have been migrated.
  5. Christian Kuhn uploaded patch set 2 CR +1 V +1 11/21/23, 12:31

  6. Oliver Klee voted on patch set 2 V +1 CR +1 11/21/23, 12:34

  7. core-ci voted on patch set 2 V +1 11/21/23, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49225

  8. Christian Kuhn voted on patch set 2 V +1 CR +1 11/21/23, 12:45

  9. Stefan Bürk voted on patch set 2 V +2 CR +2 11/21/23, 12:46

  10. Stefan Bürk merged patch set 3 11/21/23, 12:46