Review main Merged

81817[TASK] Make pagetree toggle switch accessible via keyboard

Willi Wehmeier CR +2 V +2 Easy +11 −9 updated 03/15/24, 12:01

Commit message

This change makes the toggle button accessible via keyboard
and sets the focus manually, so that the pagetree can be toggled
via pressing space or enter on the keyboard.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Willi Wehmeier uploaded patch set 1 11/21/23, 12:16

  2. core-ci voted on patch set 1 V +1 11/21/23, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49220

  3. Riccardo De Contardi commented on patch set 1 V +1 11/25/23, 10:59

    tested on latest main. (The tab order of the buttons in the area is still counterintuitive)
  4. Willi Wehmeier commented on patch set 1 12/19/23, 08:24

    Reply

    Totally agree, but we should handle this in a separate issue 😊
  5. Christian Rath-Ulrich voted on patch set 1 CR +1 V +1 01/08/24, 12:32

  6. Andreas Kienast uploaded patch set 2 CR +1 V +1 03/15/24, 08:46

  7. Andreas Kienast voted on patch set 2 CR +1 V +1 03/15/24, 08:46

  8. core-ci voted on patch set 2 V +1 03/15/24, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54570

  9. Benjamin Kott voted on patch set 2 CR +1 V +1 03/15/24, 11:20

  10. Andreas Kienast voted on patch set 2 CR +2 V +2 03/15/24, 11:51

  11. Andreas Kienast merged patch set 3 03/15/24, 12:01