Review main Merged

81819[TASK] Use `instanceof` checks for database platform aware handling

Stefan Bürk CR +2 V +2 Normal +44 −20 updated 11/21/23, 13:31

Commit message

TYPO3 provides a method to retrieve the server version prefixed
with a platform identifier, which is used in multiple places to
distinguish platform aware code.

Using `instanceof` checks is a more conveniant method to deal
with these cases - and therefore occurances are aligned now.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 912

  1. Stefan Bürk uploaded patch set 1 11/21/23, 12:30

  2. Stefan Bürk updated the commit message in patch set 2 11/21/23, 12:30

  3. Stefan Bürk wrote 11/21/23, 12:30

    Topic set to doctrine-dbal
  4. core-ci voted on patch set 2 V +1 11/21/23, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49224

  5. core-ci voted on patch set 1 V +1 11/21/23, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49223

  6. Stefan Bürk rebased onto patch set 3 V +1 11/21/23, 12:47

  7. core-ci voted on patch set 3 V +1 11/21/23, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49228

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 11/21/23, 12:58

  9. Oliver Klee voted on patch set 3 V +1 11/21/23, 13:10

  10. Oliver Klee voted on patch set 3 CR +1 11/21/23, 13:15

  11. Christian Kuhn voted on patch set 3 V +2 CR +2 11/21/23, 13:31

  12. Christian Kuhn merged patch set 4 11/21/23, 13:31