Review main Merged

81826[TASK] Change SEO field labels in pages table

Annett Jähnichen CR +2 V +2 Easy +9 −9 updated 11/21/23, 18:46

Commit message

Use dedicated and meaningful labels for the SEO fields
of the pages table. This also fixes duplicate labels
for different fields, which could previously not be
separated without having debug (field name) information.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 912

  1. Annett Jähnichen uploaded patch set 1 11/21/23, 16:41

  2. core-ci voted on patch set 1 V +1 11/21/23, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49263

  3. Oli Bartsch commented on patch set 1 11/21/23, 16:55

    What about the other tables, still using the "LGL" label?

    locallang_tca.xlf:370

    Those are now the only tables, using this term for the row description. Shouldn't this be consistent for the other tables as well?
  4. Annett Jähnichen uploaded patch set 2 V +1 11/21/23, 17:34

  5. core-ci voted on patch set 2 V +1 11/21/23, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49268

  6. Annett Jähnichen commented on patch set 2 11/21/23, 17:41

    Reply

    After the consultation, we use more context in the various description fields of the pages table instead of adding new labels.

    locallang_tca.xlf:370 Reply

    After the consultation, we use more context in the various description fields of the pages table instead of adding new labels.
  7. Jasmina Ließmann voted on patch set 2 V +1 CR +1 11/21/23, 18:02

  8. Oli Bartsch updated the commit message in patch set 3 CR +1 V +1 11/21/23, 18:26

  9. Jasmina Ließmann voted on patch set 3 V +1 CR +1 11/21/23, 18:27

  10. Oli Bartsch voted on patch set 3 V +2 CR +2 11/21/23, 18:34

  11. core-ci voted on patch set 3 V +1 11/21/23, 18:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49284

  12. Oli Bartsch merged patch set 4 11/21/23, 18:46