Review 12.4 Merged

81831[BUGFIX] Fix checking of rootline in linkvalidator

Christian Kuhn CR +2 V +2 Normal +106 −34 updated 11/21/23, 19:27

Commit message

The function `PagesRepository::doesRootLineContainHiddenPages`
did not correctly pass the pid if the function was called
recursively. This caused a premature termination of the
function.

This has now been fixed. In case a page has a page with "hidden"
and "extendToSubpages" set in any page in the rootline, this
function should now return true.

Additionally, some tests were added.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 15

Review log 34

  1. Christian Kuhn uploaded patch set 1 11/21/23, 19:04

  2. core-ci voted on patch set 1 V +1 11/21/23, 19:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49290

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 11/21/23, 19:27

  4. Christian Kuhn merged patch set 2 11/21/23, 19:27