81836[BUGFIX] Realign additional field options and arguments in scheduler task
Commit message
Review
-
Code review CR +2 Done
- Jasmina Ließmann +2
- Oli Bartsch +1
- Jochen Roth +1
- Stefan Bürk +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Jasmina Ließmann +2
- Oli Bartsch +1
- Jochen Roth +1
- Stefan Bürk +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+1 −0
- typo3/sysext/scheduler/Classes/Task/ExecuteSchedulableCommandAdditionalFieldProvider.php+39 −20
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditAdditionalFields.html+23 −0
- typo3/sysext/scheduler/Tests/Functional/Task/ExecuteSchedulableCommandAdditionalFieldProviderTest.php+2 −2
Review log 1728
Show 23 earlier messages
-
Jasmina Ließmann uploaded patch set 1 11/21/23, 21:25
-
core-ci voted on patch set 1 V -1 11/21/23, 21:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49304
-
Jasmina Ließmann uploaded patch set 2
V -111/22/23, 13:22
-
core-ci voted on patch set 2 V -1 11/22/23, 13:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49348
-
Jasmina Ließmann uploaded patch set 3
V -111/22/23, 14:02 -
Jasmina Ließmann rebased onto patch set 4 11/22/23, 14:07
-
core-ci voted on patch set 3 V -1 11/22/23, 14:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49353
-
core-ci voted on patch set 4 V -1 11/22/23, 14:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49356
-
Jasmina Ließmann updated the commit message in patch set 5
V -111/22/23, 14:21 -
Jasmina Ließmann uploaded patch set 6 11/22/23, 14:23
-
core-ci voted on patch set 5 V -1 11/22/23, 14:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49359
-
core-ci voted on patch set 6 V -1 11/22/23, 14:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49360
-
Jasmina Ließmann uploaded patch set 7
V -111/22/23, 14:35 -
Jasmina Ließmann uploaded patch set 8 11/22/23, 14:39
-
core-ci voted on patch set 7 V -1 11/22/23, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49363
-
Jasmina Ließmann updated the commit message in patch set 9 11/22/23, 14:44
-
core-ci voted on patch set 8 V -1 11/22/23, 14:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49364
-
core-ci voted on patch set 9 V -1 11/22/23, 14:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49365
-
Jochen Roth uploaded patch set 10 11/22/23, 16:05
Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**") -
Jochen Roth uploaded patch set 11
V -111/22/23, 16:07 -
core-ci voted on patch set 10 V -1 11/22/23, 16:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49392
-
core-ci voted on patch set 11 V +1 11/22/23, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49393
-
Nikita Hovratov commented on patch set 11 CR +1 V +1 11/22/23, 16:53
Looks really good! -
Oli Bartsch voted on patch set 11 CR +1 V +1 11/22/23, 17:15
-
Jochen Roth voted on patch set 11 CR +1 V +1 11/22/23, 17:43
-
Stefan Bürk voted on patch set 11 CR +1 V +1 11/22/23, 18:34
-
Jasmina Ließmann voted on patch set 11 CR +2 V +2 11/22/23, 19:48
-
Jasmina Ließmann merged patch set 12 11/22/23, 19:48