Review main Merged

81836[BUGFIX] Realign additional field options and arguments in scheduler task

Jasmina Ließmann CR +2 V +2 Normal +65 −22 updated 11/22/23, 19:48

Commit message

When editing a scheduler task, it is possible to select console commands.
These sometimes contain several field options and arguments, displayed as
checkboxes with sometimes additional input fields.

With this patch the position of the checkbox is adjusted to the
FormEngine markup. In addition, additional information about the
individual fields is no longer displayed in the field label itself, but
as a field description below the field label.

The description of the command, which is already part of the selection
field, is no longer displayed below the same field.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1728

Show 23 earlier messages
  1. Jasmina Ließmann uploaded patch set 1 11/21/23, 21:25

  2. core-ci voted on patch set 1 V -1 11/21/23, 21:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49304

  3. Jasmina Ließmann uploaded patch set 2 V -1 11/22/23, 13:22

  1. core-ci voted on patch set 2 V -1 11/22/23, 13:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49348

  2. Jasmina Ließmann uploaded patch set 3 V -1 11/22/23, 14:02

  3. Jasmina Ließmann rebased onto patch set 4 11/22/23, 14:07

  4. core-ci voted on patch set 3 V -1 11/22/23, 14:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49353

  5. core-ci voted on patch set 4 V -1 11/22/23, 14:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49356

  6. Jasmina Ließmann updated the commit message in patch set 5 V -1 11/22/23, 14:21

  7. Jasmina Ließmann uploaded patch set 6 11/22/23, 14:23

  8. core-ci voted on patch set 5 V -1 11/22/23, 14:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49359

  9. core-ci voted on patch set 6 V -1 11/22/23, 14:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49360

  10. Jasmina Ließmann uploaded patch set 7 V -1 11/22/23, 14:35

  11. Jasmina Ließmann uploaded patch set 8 11/22/23, 14:39

  12. core-ci voted on patch set 7 V -1 11/22/23, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49363

  13. Jasmina Ließmann updated the commit message in patch set 9 11/22/23, 14:44

  14. core-ci voted on patch set 8 V -1 11/22/23, 14:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49364

  15. core-ci voted on patch set 9 V -1 11/22/23, 14:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49365

  16. Jochen Roth uploaded patch set 10 11/22/23, 16:05

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  17. Jochen Roth uploaded patch set 11 V -1 11/22/23, 16:07

  18. core-ci voted on patch set 10 V -1 11/22/23, 16:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49392

  19. core-ci voted on patch set 11 V +1 11/22/23, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49393

  20. Nikita Hovratov commented on patch set 11 CR +1 V +1 11/22/23, 16:53

    Looks really good!
  21. Oli Bartsch voted on patch set 11 CR +1 V +1 11/22/23, 17:15

  22. Jochen Roth voted on patch set 11 CR +1 V +1 11/22/23, 17:43

  23. Stefan Bürk voted on patch set 11 CR +1 V +1 11/22/23, 18:34

  24. Jasmina Ließmann voted on patch set 11 CR +2 V +2 11/22/23, 19:48

  25. Jasmina Ließmann merged patch set 12 11/22/23, 19:48