81840[BUGFIX] Use config.sendCacheHeaders only for cacheable content
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Jörg Bösche +1
- Sascha Nowak +1
-
Verified V +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Sascha Nowak +1
- core-ci +1 CI
Issues 1
Files 13
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_csv/Configuration/TypoScript/JsonRenderer.typoscript+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield/Configuration/TypoScript/JsonRenderer.typoscript+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Frontend/JsonRenderer.typoscript+0 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/Frontend/ContentJsonRenderer.typoscript+0 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/Frontend/JsonRenderer.typoscript+0 −1
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/fluid_test/Configuration/TypoScript/Basic.typoscript+0 −1
- typo3/sysext/fluid_styled_content/Tests/Functional/Rendering/SecureHtmlRenderingTest.php+0 −1
- typo3/sysext/form/Tests/Functional/Fixtures/Frontend/ContentRenderer.typoscript+0 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+14 −12
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/LinkGenerator.typoscript+0 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/LinkRequest.typoscript+0 −1
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/Redirects.typoscript+0 −1
- typo3/sysext/seo/Tests/Functional/Fixtures/HrefLang.typoscript+0 −1
Review log 1519
-
Benni Mack uploaded patch set 1 11/22/23, 11:46
-
core-ci voted on patch set 1 V -1 11/22/23, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49339
-
Benni Mack commented on patch set 2
V -111/22/23, 11:55Published edit on patch set 1. -
core-ci voted on patch set 2 V +1 11/22/23, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49342
-
Oli Bartsch updated the commit message in patch set 3
V +111/22/23, 14:30 -
Oli Bartsch voted on patch set 3 CR +1 V +1 11/22/23, 14:30
-
core-ci voted on patch set 3 V +1 11/22/23, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49362
-
Sascha Nowak commented on patch set 3 CR +1 11/23/23, 08:15
## Current behavior | isClientCachable | sendCacheHeaders | expose Headers | Cache-Control | |------------------|------------------|----------------|-------------------| | true | true | true | max-age | | false | true | true | private, no-store | | false | false | true | ----- | | true | false | false | ----- | ## New behavior | isClientCachable | sendCacheHeaders | expose Headers | Cache-Control | |------------------|------------------|----------------|-------------------| | true | true | true | max-age | | false | true | true | private, no-store | | false | false | true | private, no-store | | true | false | false | ----- | -
Benjamin Franzke commented on patch set 3 11/23/23, 08:30
I'd like to know/see whether 12.4 could be an option. I mean, can we identify any cases like caching proxies or alike, that could fail with this. Also: EXT:proxycachemanager (not yet 12 compatible) EXT:varnish EXT:nginx_cache EXT:staticfilecache -
Sascha Nowak commented on patch set 3 11/23/23, 08:38
Reply
Our EXT:nxvarnish (https://github.com/netlogix/nxvarnish) is compatible with this patch. The behaviour of the setting sendCacheHeaders doesn't change. -
Benni Mack commented on patch set 3 11/23/23, 09:54
Reply
same with proxycachemanager. -
Benjamin Franzke voted on patch set 3 CR +1 11/30/23, 12:28
-
Benni Mack updated the commit message in patch set 4
CR +1V +111/30/23, 12:32 -
core-ci voted on patch set 4 V +1 11/30/23, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50164
-
Jörg Bösche voted on patch set 4 CR +1 11/30/23, 12:41
-
Benjamin Franzke voted on patch set 4 CR +1 V +1 11/30/23, 13:01
-
Sascha Nowak voted on patch set 4 CR +1 V +1 11/30/23, 13:02
-
Benni Mack commented on patch set 4 CR +2 V +2 11/30/23, 13:03
Reply
Done -
Benni Mack merged patch set 5 11/30/23, 13:03