Review main Merged

81841[BUGFIX] Avoid double base64 encoding for reused ConsumableNonce

Michael Binder CR +2 V +2 Normal +58 −1 updated 11/22/23, 20:26

Commit message

Only base64 encode if a new nonce value has been created.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Michael Binder uploaded patch set 1 11/22/23, 11:47

  2. core-ci voted on patch set 1 V +1 11/22/23, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49340

  3. Oli Bartsch voted on patch set 1 CR +1 11/22/23, 14:34

  4. Oliver Hader commented on patch set 1 11/22/23, 16:56

    on it...
  5. Oliver Hader uploaded patch set 2 CR +1 V +1 11/22/23, 17:26

  6. core-ci voted on patch set 2 V +1 11/22/23, 17:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49406

  7. Oliver Hader voted on patch set 2 CR +1 V +1 11/22/23, 17:40

  8. Stefan Bürk voted on patch set 2 CR +1 V +1 11/22/23, 18:35

  9. Stefan Bürk voted on patch set 2 CR +2 V +2 11/22/23, 20:14

  10. Oli Bartsch voted on patch set 2 CR +1 V +1 11/22/23, 20:16

  11. Stefan Bürk merged patch set 3 11/22/23, 20:26