Review main Merged

81857[BUGFIX] Visually remove all translations in record list when deleting main record

Andreas Kienast CR +2 V +2 Easy +4 −5 updated 11/22/23, 21:02

Commit message

When deleting a main record in the record list, only the first
translated record was removed from the list. This affects the visual
representation only. This commit changes the code to take all translated
records into consideration.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • Sascha Nowak +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1419

  1. Andreas Kienast uploaded patch set 1 11/22/23, 14:58

  2. Andreas Kienast updated the commit message in patch set 2 11/22/23, 14:59

  3. core-ci voted on patch set 1 V -1 11/22/23, 15:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49368

  4. core-ci voted on patch set 2 V -1 11/22/23, 15:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49369

  5. Oli Bartsch voted on patch set 2 CR +1 V +1 11/22/23, 15:31

  6. Andreas Kienast uploaded patch set 3 CR +1 V +1 11/22/23, 15:32

  7. core-ci voted on patch set 3 V +1 11/22/23, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49379

  8. Andreas Kienast uploaded patch set 4 V +1 11/22/23, 16:19

  9. core-ci voted on patch set 4 V +1 11/22/23, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49395

  10. Sascha Nowak commented on patch set 4 11/22/23, 16:53

    ajax-data-handler.ts:247

    This should not be necessary after using querySelectorAll. querySelectorAll would return an empty NodeList and the forEach is not executed.
  11. Andreas Kienast commented on patch set 4 CR -1 11/22/23, 16:59

    ajax-data-handler.ts:247 Reply

    Of course that's true.
  12. Andreas Kienast uploaded patch set 5 CR -1 V +1 11/22/23, 17:00

  13. Oli Bartsch voted on patch set 5 CR +1 V +1 11/22/23, 17:00

  14. Andreas Kienast commented on patch set 5 11/22/23, 17:00

    ajax-data-handler.ts:247 Reply

    Done
  15. Sascha Nowak voted on patch set 5 CR +1 11/22/23, 17:01

  16. core-ci voted on patch set 5 V +1 11/22/23, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49402

  17. Jochen Roth voted on patch set 5 CR +1 V +1 11/22/23, 20:50

  18. Andreas Kienast voted on patch set 5 CR +2 V +2 11/22/23, 20:55

  19. Andreas Kienast merged patch set 6 11/22/23, 21:02