Review main Merged

81858[TASK] Remove jQuery from Extension Manager

Andreas Nedbal CR +2 V +2 Normal +79 −57 updated 11/22/23, 20:55

Commit message

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1114

  1. Andreas Nedbal uploaded patch set 1 11/22/23, 15:00

  2. core-ci voted on patch set 1 V +1 11/22/23, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49371

  3. Andreas Nedbal uploaded patch set 2 V +1 11/22/23, 18:24

  4. core-ci voted on patch set 2 V +1 11/22/23, 18:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49420

  5. Jochen Roth voted on patch set 2 CR +1 V +1 11/22/23, 18:35

  6. Andreas Kienast commented on patch set 2 11/22/23, 20:21

    repository.ts:127

    Is it safe that `e.currentTarget` is the expected element?
  7. Andreas Kienast commented on patch set 2 CR +1 V +1 11/22/23, 20:32

    repository.ts:127 Reply

    Done
  8. Andreas Kienast commented on patch set 2 CR 0 V -1 11/22/23, 20:34

    Toggling the upload form doesn't work anymore. You can expand, but not collapse it.
  9. Andreas Kienast uploaded patch set 3 CR +1 V +1 11/22/23, 20:38

  10. core-ci voted on patch set 3 V +1 11/22/23, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49526

  11. Jochen Roth voted on patch set 3 CR +1 V +1 11/22/23, 20:45

  12. Andreas Kienast voted on patch set 3 CR +1 V +1 11/22/23, 20:46

  13. Andreas Kienast voted on patch set 3 CR +2 V +2 11/22/23, 20:55

  14. Andreas Kienast merged patch set 4 11/22/23, 20:55