Review main Merged

81859[BUGFIX] Set maxlength for varchar inputs in sys_file_metadata

Willi Wehmeier CR +2 V +2 Easy +10 −1 updated 11/29/23, 04:41

Commit message

Max values have been set to the input fields in the TCA of the
sys_file_metadata table. The settings have been adjusted to the
set varchar length in the ext_tables.sql file.

Additionally the language column length has been adjusted to
the other fields. The length is set from 12 to 45.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 913

  1. Willi Wehmeier uploaded patch set 1 11/22/23, 15:15

  2. core-ci voted on patch set 1 V +1 11/22/23, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49376

  3. Willi Wehmeier uploaded patch set 2 V +1 11/28/23, 06:10

  4. core-ci voted on patch set 2 V +1 11/28/23, 06:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50042

  5. Simon Schaufelberger commented on patch set 2 11/28/23, 09:10

    ext_tables.sql:5

    can you please only change the lines which you want to change and not all?
  6. Willi Wehmeier uploaded patch set 3 V +1 11/28/23, 09:23

  7. core-ci voted on patch set 3 V +1 11/28/23, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50045

  8. Willi Wehmeier uploaded patch set 4 V +1 11/28/23, 09:29

  9. Willi Wehmeier commented on patch set 4 11/28/23, 09:30

    ext_tables.sql:5 Reply

    Done :)
  10. core-ci voted on patch set 4 V +1 11/28/23, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50046

  11. Simon Schaufelberger voted on patch set 4 CR +1 V +1 11/28/23, 19:54

  12. Christian Kuhn voted on patch set 4 CR +2 V +2 11/29/23, 04:41

  13. Christian Kuhn merged patch set 5 11/29/23, 04:41