81863[BUGFIX] Avoid calling method on unavailable `frontend.typoscript`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1316
-
Markus Gerdes uploaded patch set 1 11/22/23, 16:20
-
core-ci voted on patch set 1 V +1 11/22/23, 16:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49396
-
Stefan Bürk voted on patch set 1 CR -1 11/22/23, 20:15
-
Simon Schaufelberger commented on patch set 1 CR -1 11/23/23, 07:47
this seams like a bug in the extension -
Markus Gerdes commented on patch set 1 11/23/23, 07:55
Reply
Hi @simonschaufi+typo3@gmail.com, I agree and have opened a pull request for a small fix for the extension. But I would excpect the TYPO3 core to handle the known possiblity that the getAttribute could return null . At least in TYPO3 v12 where this is written in the comments. Maybe an Exception should be thrown as in the 'getSetupArray` of FrontendTypoScript class ? -
Stefan Bürk uploaded patch set 2
CR -1V +111/24/23, 15:51 -
Stefan Bürk updated the commit message in patch set 3 11/24/23, 15:52
-
Stefan Bürk commented on patch set 3 CR +1 V +1 11/24/23, 15:53
Reply
Done -
core-ci voted on patch set 2 V +1 11/24/23, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49895
-
core-ci voted on patch set 3 V +1 11/24/23, 15:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49896
-
Oli Bartsch voted on patch set 3 CR +1 V +1 11/24/23, 18:37
-
Oliver Klee voted on patch set 3 CR +1 11/24/23, 18:43
-
Christian Kuhn commented on patch set 3 CR -1 11/25/23, 15:01
will update: i think we should throw in v13 right away and just have a slightly different variant for v12 then. -
Christian Kuhn commented on patch set 3 CR +1 V +1 11/25/23, 15:18
ah, another patch is pending already. ok. so we pick this one as is. -
Stefan Bürk voted on patch set 3 CR +2 V +2 11/25/23, 15:32
-
Stefan Bürk merged patch set 4 11/25/23, 16:21