Review main Merged

81866[BUGFIX] Update display of start page field in "LinkValidator" task

Jasmina Ließmann CR +2 V +2 Easy +28 −12 updated 11/23/23, 15:21

Commit message

In the "LinkValidator" scheduler task, you need to select a start page.
The button to select this page does not match the FormEngine markup.
which is fixed with this patch.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 811

  1. Jasmina Ließmann uploaded patch set 1 11/22/23, 17:04

  2. core-ci voted on patch set 1 V +1 11/22/23, 17:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49403

  3. Jochen Roth voted on patch set 1 CR +1 V +1 11/22/23, 20:32

  4. Stefan Bürk commented on patch set 1 CR -1 11/22/23, 21:10

    Due to the change, if a page is selected it is replaced on save with something similar to ``` styleguide frontend demo [pages_177] ``` saving again will fail. This is also valid if record is closed and reopened.
  5. Jasmina Ließmann uploaded patch set 2 CR +1 V +1 11/23/23, 13:51

  6. Jasmina Ließmann uploaded patch set 3 11/23/23, 13:52

  7. core-ci voted on patch set 3 V +1 11/23/23, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49693

  8. core-ci voted on patch set 2 V -1 11/23/23, 14:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49692

  9. Stefan Bürk commented on patch set 3 CR +1 V +1 11/23/23, 14:55

    Reply

    solved
  10. Christian Kuhn voted on patch set 3 CR +2 V +2 11/23/23, 15:08

  11. Christian Kuhn merged patch set 4 11/23/23, 15:21