81869[TASK] Hide buttons with no impact
Commit message
Review
-
Code review CR +2 Done
- Annett Jähnichen +2
- Jochen Roth +1
- Andreas Kienast +1
-
Verified V +2 Done
- Annett Jähnichen +2
- Jochen Roth +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1317
-
Annett Jähnichen uploaded patch set 1 11/22/23, 17:36
-
core-ci voted on patch set 1 V +1 11/22/23, 17:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49409
-
Jochen Roth voted on patch set 1 CR +1 V +1 11/22/23, 17:52
-
Andreas Kienast commented on patch set 1 CR -1 11/22/23, 18:21
This is either a TASK or a BUGFIX, but no feature. This would also miss the ReST file.processing-indicator.ts:48Why do we need a new CSS class? Can't we use the `hidden` attribute instead? -
Jochen Roth commented on patch set 1 11/22/23, 18:54
processing-indicator.ts:48Replyon it -
Jochen Roth uploaded patch set 2
CR +1V +111/22/23, 19:30 -
Jochen Roth commented on patch set 2 CR +1 V +1 11/22/23, 19:32
processing-indicator.ts:48ReplyDone -
Andreas Kienast updated the commit message in patch set 3
CR +1V +111/22/23, 19:37 -
core-ci voted on patch set 2 V +1 11/22/23, 19:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49483
-
Andreas Kienast commented on patch set 3 11/22/23, 19:38
processing-indicator.ts:48`target.hidden = true`? -
core-ci voted on patch set 3 V +1 11/22/23, 19:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49491
-
Andreas Kienast uploaded patch set 4
V +111/22/23, 19:43 -
Andreas Kienast commented on patch set 4 CR +1 V +1 11/22/23, 19:43
processing-indicator.ts:48ReplyDone -
Jochen Roth voted on patch set 4 CR +1 V +1 11/22/23, 19:46
-
core-ci voted on patch set 4 V +1 11/22/23, 19:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49495
-
Annett Jähnichen voted on patch set 4 CR +2 V +2 11/22/23, 19:50
-
Annett Jähnichen merged patch set 5 11/22/23, 19:50