Review main Merged

81874[BUGFIX] Prevent creating TS setup tree twice

Christian Kuhn CR +2 V +2 Easy +2 −1 updated 11/27/23, 16:33

Commit message

Avoid a second fetch of TS 'setup include tree'
in TypoScriptFrontendController when it just
has been calculated a couple of lines before.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 812

  1. Christian Kuhn uploaded patch set 1 11/22/23, 20:04

  2. core-ci voted on patch set 1 V +1 11/22/23, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49518

  3. core-ci commented on patch set 1 11/22/23, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49519

  4. Christian Kuhn uploaded patch set 2 V +1 11/23/23, 13:39

  5. core-ci voted on patch set 2 V +1 11/23/23, 13:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49690

  6. Benjamin Franzke voted on patch set 2 CR +1 11/23/23, 14:05

  7. Benjamin Franzke voted on patch set 2 V +1 11/23/23, 14:07

  8. core-ci commented on patch set 2 11/23/23, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49691

  9. Stefan Bürk voted on patch set 2 CR +1 V +1 11/23/23, 14:51

  10. Christian Kuhn voted on patch set 2 CR +2 V +2 11/23/23, 14:51

  11. Christian Kuhn merged patch set 3 11/23/23, 14:51

  12. Christian Kuhn commented on patch set 3 11/27/23, 16:33

    this one was meant to fix https://forge.typo3.org/issues/102485