Review main Merged

81875[TASK] Remove ext:saltedpasswords specific code in tests

Torben Hansen CR +2 V +2 Easy +11 −14 updated 11/22/23, 20:40

Commit message

3 unit tests define ext:saltedpasswords related extension
settings, which however have no effect anymore.

This change removes the superfluous settings in the tests.
Additionally the term `saltedpasswords` is replaced with
`felogin` in `ListUtilityTest`.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Torben Hansen uploaded patch set 1 11/22/23, 20:18

  2. core-ci voted on patch set 1 V +1 11/22/23, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49521

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 11/22/23, 20:27

  4. Stefan Bürk voted on patch set 1 CR +2 V +2 11/22/23, 20:40

  5. Stefan Bürk merged patch set 2 11/22/23, 20:40