Review main Merged

81880[TASK] Add missing multi record selection to redirects module

Oli Bartsch CR +2 V +2 Normal +109 −7 updated 11/23/23, 13:51

Commit message

This adds the missing multi record selection with
basic functionality (edit and delete records) to
the redirects module.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Annett Jähnichen +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1012

  1. Oli Bartsch uploaded patch set 1 11/22/23, 21:09

  2. core-ci voted on patch set 1 V +1 11/22/23, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49554

  3. Stefan Bürk commented on patch set 1 CR -1 11/22/23, 21:26

    Selecting multiple (two) redirects and clicking "delete" only deletes one record, not all
  4. Oli Bartsch uploaded patch set 2 CR -1 V +1 11/22/23, 21:30

  5. core-ci voted on patch set 2 V +1 11/22/23, 21:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49561

  6. Oli Bartsch commented on patch set 2 11/22/23, 22:23

    Reply

    can confirm. however this seems to be a bug in the delete component as it’s the same for other modules, e.g. reactions and webhooks. will fix this in a separate patch.
  7. Oli Bartsch commented on patch set 2 11/23/23, 07:57

    Reply

  8. Annett Jähnichen voted on patch set 2 V +1 11/23/23, 09:23

  9. Jochen Roth voted on patch set 2 CR +1 V +1 11/23/23, 10:13

  10. Stefan Bürk voted on patch set 2 CR +1 V +1 11/23/23, 11:46

  11. Oli Bartsch voted on patch set 2 CR +2 V +2 11/23/23, 13:37

  12. Oli Bartsch merged patch set 3 11/23/23, 13:51