81880[TASK] Add missing multi record selection to redirects module
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Stefan Bürk +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Annett Jähnichen +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Tests/Acceptance/Application/Redirect/RedirectModuleCest.php+4 −4
- typo3/sysext/redirects/Classes/Controller/ManagementController.php+15 −0
- typo3/sysext/redirects/Resources/Private/Language/locallang_module_redirect.xlf+7 −0
- typo3/sysext/redirects/Resources/Private/Templates/Management/Overview.html+83 −3
Review log 1012
-
Oli Bartsch uploaded patch set 1 11/22/23, 21:09
-
core-ci voted on patch set 1 V +1 11/22/23, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49554
-
Stefan Bürk commented on patch set 1 CR -1 11/22/23, 21:26
Selecting multiple (two) redirects and clicking "delete" only deletes one record, not all -
Oli Bartsch uploaded patch set 2
CR -1V +111/22/23, 21:30 -
core-ci voted on patch set 2 V +1 11/22/23, 21:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49561
-
Oli Bartsch commented on patch set 2 11/22/23, 22:23
Reply
can confirm. however this seems to be a bug in the delete component as it’s the same for other modules, e.g. reactions and webhooks. will fix this in a separate patch. -
Oli Bartsch commented on patch set 2 11/23/23, 07:57
Reply
Created an issue https://forge.typo3.org/issues/102475 -
Annett Jähnichen voted on patch set 2 V +1 11/23/23, 09:23
-
Jochen Roth voted on patch set 2 CR +1 V +1 11/23/23, 10:13
-
Stefan Bürk voted on patch set 2 CR +1 V +1 11/23/23, 11:46
-
Oli Bartsch voted on patch set 2 CR +2 V +2 11/23/23, 13:37
-
Oli Bartsch merged patch set 3 11/23/23, 13:51