81881[FEATURE] Introduce CacheTagCollector Api
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 30
- typo3/sysext/core/Classes/Cache/Event/AddCacheTagEvent.phpnew+25 −0
- typo3/sysext/core/Classes/Cache/CacheEntry.phpnew+39 −0
- typo3/sysext/core/Classes/Cache/CacheTag.phpnew+26 −0
- typo3/sysext/core/Classes/Cache/RequestCacheCollector.phpnew+90 −0
- typo3/sysext/core/Classes/Cache/RequestCacheCollectorInterface.phpnew+41 −0
- typo3/sysext/core/Classes/Middleware/RequestCacheAttribute.phpnew+75 −0
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+20 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102422-MethodSignatureChangeOfTypoScriptFrontendControllerApplyHttpHeadersToResponse.rstnew+42 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Deprecation-102422-RequestCacheCollector.rstnew+55 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-102422-RequestCacheCollector.rstnew+100 −0
- typo3/sysext/core/Tests/Unit/Cache/CacheTagCollectorTest.phpnew+150 −0
- typo3/sysext/core/Tests/Unit/Cache/CacheTagTest.phpnew+47 −0
- typo3/sysext/core/Tests/Unit/Middleware/CacheTagsAttributeTest.phpnew+45 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php2+24 −6
- typo3/sysext/extbase/Classes/Persistence/Repository.php3+53 −2
- typo3/sysext/extbase/Classes/Service/CacheService.php2+24 −10
- typo3/sysext/extbase/Tests/Unit/Persistence/RepositoryTest.php+42 −4
- typo3/sysext/extbase/Tests/Unit/Service/CacheServiceTest.php+38 −8
- typo3/sysext/frontend/Classes/Cache/CacheLifetimeCalculator.php1+45 −13
- typo3/sysext/frontend/Classes/ContentObject/ContentContentObject.php1+24 −0
Show 10 more files
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+13 −4
- typo3/sysext/frontend/Classes/ContentObject/RecordsContentObject.php+24 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+70 −47
- typo3/sysext/frontend/Classes/Event/ModifyCacheLifetimeForRowEvent.phpnew+31 −0
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+1 −1
- typo3/sysext/frontend/Classes/Middleware/CacheTimeout.phpnew+49 −0
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+27 −0
- typo3/sysext/frontend/Configuration/RequestMiddlewares.php+19 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+26 −19
- .phpstorm.meta.php+2 −0
Review log 811
-
Sascha Nowak uploaded patch set 1 11/22/23, 21:23
-
core-ci voted on patch set 1 V -1 11/22/23, 21:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49556
-
Sascha Nowak uploaded patch set 2
V -111/23/23, 09:52 -
core-ci voted on patch set 2 V -1 11/23/23, 09:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49620
-
Sascha Nowak uploaded patch set 3
V -111/23/23, 14:19 -
core-ci voted on patch set 3 V -1 11/23/23, 14:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49701
-
Benjamin Franzke commented on patch set 3 11/23/23, 15:02
Typo3DbBackend.php:614UnresolvedinjectRepository.php:234UnresolvedUse addTableToCacheTags here?Repository.php:282UnresolvedUse addTableToCacheTags here?Repository.php:360Unresolvedinject via injectEventDispatcher() method and mark property nullable and always call via optional chainingCacheService.php:180Unresolvedlooks wrong in general as pageId cache-tag should already be added by TSFE on its own(?)CacheService.php:199UnresolvedMaybe not needed as already tagged in Repository via addTableToCacheTags?CacheLifetimeCalculator.php:77Unresolvedas you said in personal discussion: This piece might be backported as bugfixContentContentObject.php:170Unresolvedwould be nice to be TSFE config agnostic. E.g. handle things like clearCacheAtMidnight in a central place (middleware?) in order to limit maximum cache tag lifetime in a central place. -
Sascha Nowak uploaded patch set 4
V -111/24/23, 08:33 -
Sascha Nowak uploaded patch set 5 11/24/23, 09:19
-
Sascha Nowak uploaded patch set 6 11/24/23, 09:22
-
Sascha Nowak abandoned the change 11/24/23, 09:26
Typo3DbBackend.php:600Unresolved