Review main Merged

81884[TASK] Remove doktype 255 (recycler) from excludedDoktypes in EXT:seo

Chris Müller CR +2 V +2 Easy +2 −2 updated 11/23/23, 14:56

Commit message

The page doktype "recycler" has been removed. So, we don't need to
exclude it anymore in the default TypoScript constants configuration
in `plugin.tx_seo.settings.xmlSitemap.sitemaps.pages.excludedDoktypes`.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1114

  1. Chris Müller uploaded patch set 1 11/23/23, 06:53

  2. core-ci voted on patch set 1 V +1 11/23/23, 06:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49575

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 11/23/23, 07:09

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 11/23/23, 07:40

  5. Annett Jähnichen commented on patch set 1 11/23/23, 11:49

    Can we remove it also in sysext/seo/Configuration/Services.yaml ?
  6. Annett Jähnichen uploaded patch set 2 CR +1 V +1 11/23/23, 11:53

  7. core-ci voted on patch set 2 V +1 11/23/23, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49654

  8. Annett Jähnichen commented on patch set 2 11/23/23, 14:03

    Reply

    Done
  9. Stefan Bürk updated the commit message in patch set 3 V +1 11/23/23, 14:05

  10. Stefan Bürk voted on patch set 3 CR +1 V +1 11/23/23, 14:07

  11. Oliver Hader voted on patch set 3 CR +1 11/23/23, 14:11

  12. core-ci voted on patch set 3 V +1 11/23/23, 14:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49699

  13. Christian Kuhn voted on patch set 3 CR +2 V +2 11/23/23, 14:56

  14. Christian Kuhn merged patch set 4 11/23/23, 14:56