81891[BUGFIX] Show correct old name when renaming files/folders
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Oliver Hader +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1316
-
Daniel Hoffmann uploaded patch set 1 11/23/23, 10:47
-
core-ci voted on patch set 1 V +1 11/23/23, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49636
-
Josef Glatz voted on patch set 1 CR -1 V -1 11/23/23, 11:04
-
Josef Glatz commented on patch set 1 11/28/23, 18:30
Hi Daniel! Cool to see your first commit! My downvote targets only the commit message as there is no heading and no (optional) body. Please checkout https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/Appendix/CommitMessage.html for details. Why did I -1 on verfied? Even if someone can test your patch. Such an patch must contain all infos right in the commit message. A visit of the issue should not be needed. looking forward to your update :-) cheers, Josef -
Christian Kuhn uploaded patch set 2
CR -1V +111/29/23, 05:20 -
Christian Kuhn updated the commit message in patch set 3 11/29/23, 05:23
-
Christian Kuhn voted on patch set 3 CR +1 V +1 11/29/23, 05:24
-
core-ci voted on patch set 2 V +1 11/29/23, 05:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50081
-
core-ci voted on patch set 3 V +1 11/29/23, 05:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50082
-
Garvin Hicking voted on patch set 3 CR +1 V +1 11/29/23, 08:38
-
Daniel Hoffmann commented on patch set 3 11/29/23, 17:02
Sorry for the incorrect commit message, i came to fix it now but someone was faster :-) -
Oliver Hader voted on patch set 3 CR +1 11/29/23, 17:44
-
Oli Bartsch commented on patch set 3 11/29/23, 17:53
Why do we change visibilities to private? Class is already marked as @internal. There is IMO no reason for those changes. -
Christian Kuhn commented on patch set 3 11/29/23, 17:56
Reply
I found the obsolete DI this way. And since the class is final, there is no point in *not* making the methods private. -
Christian Kuhn voted on patch set 3 CR +2 V +2 11/29/23, 18:01
-
Christian Kuhn merged patch set 4 11/29/23, 18:01