Review main Merged

81904Revert "[TASK] Make clearable button more accessible"

Andreas Kienast CR +2 V +2 Easy +7 −16 updated 11/24/23, 10:28

Commit message

This reverts commit 2a05d2844d514918ec2c73cdeab9fcab199d222e.

The proposed and merged solution decreases the overall usability in the
TYPO3 backend as users are now forced to press the <TAB> key twice to
actually switch the focus to another field.

One could also argue that the change that is reverted is not suitable
for the target group that mostly uses keyboard navigation as said users
were already able to clear fields previously.

Once we have a solution that satisfies both target groups, another
patch will be pushed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 78

  1. Andreas Kienast uploaded patch set 1 11/24/23, 09:34

  2. Andreas Kienast updated the commit message in patch set 2 11/24/23, 09:34

  3. Christian Kuhn commented on patch set 2 CR +1 V +1 11/24/23, 09:38

    Thanks. This makes sense.
  4. Oli Bartsch voted on patch set 2 CR +1 V +1 11/24/23, 09:42

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 11/24/23, 09:50

  6. Andreas Kienast voted on patch set 2 CR +2 V +2 11/24/23, 09:56

  7. core-ci voted on patch set 2 V +1 11/24/23, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49859

  8. Andreas Kienast merged patch set 3 11/24/23, 10:28