Review 12.4 Merged

81905Revert "[TASK] Make clearable button more accessible"

Andreas Kienast CR +2 V +2 Easy +7 −16 updated 11/24/23, 10:28

Commit message

This reverts commit 75b558b6ee7a534462538d3356d9a4630ebc9201.

The proposed and merged solution decreases the overall usability in the
TYPO3 backend as users are now forced to press the <TAB> key twice to
actually switch the focus to another field.

One could also argue that the change that is reverted is not suitable
for the target group that mostly uses keyboard navigation as said users
were already able to clear fields previously.

Once we have a solution that satisfies both target groups, another
patch will be pushed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 45

  1. Andreas Kienast uploaded patch set 1 11/24/23, 09:55

  2. Andreas Kienast voted on patch set 1 CR +2 V +2 11/24/23, 09:56

  3. Jochen Roth voted on patch set 1 CR +1 V +1 11/24/23, 10:01

  4. core-ci voted on patch set 1 V +1 11/24/23, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49865

  5. Andreas Kienast merged patch set 2 11/24/23, 10:28