Review 11.5 Merged

81925[BUGFIX] Use correct `Configuration` ignore in namespace integrity check

Stefan Bürk CR +2 V +2 Easy +7 −2 updated 11/23/23, 15:29

Commit message

The php namespace integrity check uses a symfony
finder to determine which files should be checked.
The used pattern to ignore extension configuration
folder `Configuration` excluded every file,  which
has `Configuration` in the path or filename.

This change avoids using the nifty magic `exclude()`
finder method and replace it with a more reliable
`notPath()` configuration.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 59

  1. Stefan Bürk uploaded patch set 1 11/23/23, 15:06

  2. Stefan Bürk uploaded patch set 2 11/23/23, 15:07

  3. Christian Kuhn uploaded patch set 3 11/23/23, 15:10

  4. core-ci voted on patch set 1 V -1 11/23/23, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49709

  5. core-ci voted on patch set 3 V +1 11/23/23, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49712

  6. core-ci voted on patch set 1 V +1 11/23/23, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49709

  7. core-ci voted on patch set 2 V +1 11/23/23, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49710

  8. Christian Kuhn voted on patch set 3 CR +2 V +2 11/23/23, 15:29

  9. Christian Kuhn merged patch set 4 11/23/23, 15:29