Review main Merged

81934[TASK] Avoid deprecated `Platform->getStringLiteralQuoteCharacter()`

Stefan Bürk CR +2 V +2 Easy +16 −20 updated 11/23/23, 19:15

Commit message

The doctrine team deprecated within `doctrine/dbal 3.x` the
`Platform->getStringLiteralQuoteCharacter()`, postulating
that this is a implementation detail and not a public required
information [1][2].

TYPO3 extends a couple of classes to provide some advanced
abilities to help extension author's avoiding casual safety
traps and additional features. The `ExpressionBuilder` is
one of these classes. Extended methods quotes values per
default, and therefore requires to unquote values at some
points to avoid double quoting of values.

This change removes the call to the deprecated method on
the platform and directly replaces it with the value, as
all supported platforms will return the same quoting char.

Tests are adjusted accordingly.

[1] https://github.com/doctrine/dbal/blob/3.7.x/UPGRADE.md#deprecated-abstractplatform-methods-exposing-quote-characters
[2] https://github.com/doctrine/dbal/pull/5388

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 915

  1. Stefan Bürk uploaded patch set 1 11/23/23, 17:41

  2. core-ci voted on patch set 1 V +1 11/23/23, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49799

  3. Stefan Bürk uploaded patch set 2 V +1 11/23/23, 17:50

  4. Stefan Bürk updated the commit message in patch set 3 11/23/23, 17:51

  5. core-ci voted on patch set 2 V +1 11/23/23, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49802

  6. core-ci voted on patch set 3 V +1 11/23/23, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49804

  7. core-ci voted on patch set 2 V +1 11/23/23, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49803

  8. Christian Kuhn uploaded patch set 4 V +1 11/23/23, 18:52

  9. core-ci voted on patch set 4 V -1 11/23/23, 18:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49812

  10. Christian Kuhn uploaded patch set 5 V -1 11/23/23, 19:01

  11. core-ci voted on patch set 5 V +1 11/23/23, 19:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49816

  12. Christian Kuhn voted on patch set 5 CR +1 V +1 11/23/23, 19:13

  13. Andreas Nedbal voted on patch set 5 CR +1 V +1 11/23/23, 19:14

  14. Christian Kuhn voted on patch set 5 CR +2 V +2 11/23/23, 19:15

  15. Christian Kuhn merged patch set 6 11/23/23, 19:15