Review main Merged

81939[TASK] Remove usage of three deprecated `AbstractPlatform` methods

Stefan Bürk CR +2 V +2 Easy +8 −3 updated 11/23/23, 18:49

Commit message

Doctrine DBAL depreated a couple of `AbstractPlatform methods [1]
producing SQL fragments which does not vary between platforms.
Following methods from the deprecated list are in use:

* `AbstractPlatform->getSqlCommentStartString()`
* `AbstractPlatform->getSqlCommentEndString()`
* `AbstractPlatform->getCountExpression()`

This change replace the occurances with the plain values.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Andreas Nedbal +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Andreas Nedbal +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Stefan Bürk uploaded patch set 1 11/23/23, 18:23

  2. core-ci voted on patch set 1 V +1 11/23/23, 18:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49811

  3. Andreas Nedbal voted on patch set 1 CR +1 V +1 11/23/23, 18:48

  4. Christian Kuhn voted on patch set 1 CR +1 V +1 11/23/23, 18:48

  5. Stefan Bürk voted on patch set 1 CR +2 V +2 11/23/23, 18:49

  6. Stefan Bürk merged patch set 2 11/23/23, 18:49