Review main Merged

81946[FEATURE] Introduce global Doctrine DBAL driver middlewares

Stefan Bürk CR +2 V +2 Normal +74 −6 updated 11/26/23, 10:31

Commit message

Since v3, Doctrine DBAL supports adding custom driver
middlewares. These middlewares act as a decorator around
the actual `Driver` component.

Since #100089 it's possible to configure driver middlewares
for a specific database connection based on the Doctrine DBAL
driver middlewares along with some specific middlewares.

To prepare for Doctrine DBAL v4 upgrade, a mandantory global
driver middleware `CustomPlatformDriverMiddleware` has been
added with #102402.

With this feature, global connection driver middlewares are
now added as a configurable option and the already specific
core middleware is added to the default configuration.

Global driver middlewares can now be configured in

    /** array<int|string, string> **/
    $GLOBALS['TYPO3_CONF_VARS']['DB']['globalDriverMiddlewares']

and are replaced with the specific connection driver middlewares.

The `global` => `specific` order allows to register a global
middleware, but disable it for a specific middleware later on.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 1216

  1. Stefan Bürk uploaded patch set 1 11/23/23, 21:38

  2. core-ci voted on patch set 1 V +1 11/23/23, 21:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49824

  3. Stefan Bürk uploaded patch set 2 V +1 11/24/23, 11:09

  4. Stefan Bürk updated the commit message in patch set 3 11/24/23, 11:09

  5. Stefan Bürk updated the commit message in patch set 4 11/24/23, 11:09

  6. core-ci voted on patch set 4 V +1 11/24/23, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49884

  7. Stefan Bürk uploaded patch set 5 V +1 11/24/23, 11:28

  8. core-ci voted on patch set 5 V +1 11/24/23, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49886

  9. Oliver Klee voted on patch set 5 V +1 11/25/23, 20:34

  10. Christian Kuhn uploaded patch set 6 V +1 11/26/23, 10:20

  11. Christian Kuhn voted on patch set 6 CR +1 V +1 11/26/23, 10:21

  12. core-ci voted on patch set 6 V +1 11/26/23, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49946

  13. Oliver Klee voted on patch set 6 V +1 11/26/23, 10:30

  14. Oliver Klee voted on patch set 6 CR +1 11/26/23, 10:31

  15. Christian Kuhn voted on patch set 6 CR +2 V +2 11/26/23, 10:31

  16. Christian Kuhn merged patch set 7 11/26/23, 10:31