Review main Merged

81948[TASK] Clean up extension manager code

Benni Mack CR +2 V +2 Hard +196 −569 updated 01/23/24, 16:37

Commit message

This change adapts various strict types, and reduces
some injection within EXT:extensionmanager.

The main issue is: There are main circular dependencies
between Utility classes, which should slowly dissolve,
some safe places have been considered now to
be adapted further in subsequenting patches

In addition, all code is now strict-typed,
as all code is internal within EXT:extensionmanager
this is now finally taken care of.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 27

Show 7 more files

Review log 1825

  1. Benni Mack uploaded patch set 1 11/24/23, 08:05

  2. core-ci voted on patch set 1 V -1 11/24/23, 08:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49833

  3. Benni Mack uploaded patch set 2 V -1 01/23/24, 11:05

  4. core-ci voted on patch set 2 V +1 01/23/24, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51986

  5. Benni Mack updated the commit message in patch set 3 V +1 01/23/24, 11:24

  6. core-ci voted on patch set 3 V +1 01/23/24, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51988

  7. Andreas Kienast commented on patch set 3 01/23/24, 13:21

    DownloadQueue.php:2

    `declare(strict_types=1)`?

    ExtensionManagementService.php:2

    `declare(strict_types=1)`?
  8. Christian Kuhn commented on patch set 3 CR -1 01/23/24, 13:26

    TerExtensionRemote.php:141

    $pathType argument unused. remove?

    FileHandlingUtility.php:44

    it looks as if this is never reset to anything else. Let's define this as private const to clarify this service is stateless (apart from the __construct() initialized LanguageService).
  9. Benni Mack uploaded patch set 4 CR -1 V +1 01/23/24, 14:09

  10. Benni Mack commented on patch set 4 01/23/24, 14:10

    DownloadQueue.php:2 Reply

    Done

    TerExtensionRemote.php:141 Reply

    it's in the interface, so I want to keep it like this for the time being

    ExtensionManagementService.php:2 Reply

    Done

    FileHandlingUtility.php:44 Reply

    Done
  11. Benni Mack updated the commit message in patch set 5 01/23/24, 14:11

  12. core-ci voted on patch set 4 V -1 01/23/24, 14:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52001

  13. core-ci voted on patch set 5 V -1 01/23/24, 14:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52003

  14. Benni Mack uploaded patch set 6 V -1 01/23/24, 14:38

  15. core-ci voted on patch set 6 V +1 01/23/24, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52007

  16. Christian Kuhn voted on patch set 6 CR +1 V +1 01/23/24, 14:46

  17. Andreas Kienast commented on patch set 6 V -1 01/23/24, 15:20

    When opening the Extension Manager, I get ``` Typed property TYPO3\CMS\Extensionmanager\Domain\Model\Extension::$dependencies must not be accessed before initialization ```
  18. Christian Kuhn voted on patch set 6 CR 0 V 0 01/23/24, 15:26

  19. Stefan Bürk commented on patch set 6 01/23/24, 15:55

    Reply

    interessting - i'm not oO
  20. Stefan Bürk commented on patch set 6 01/23/24, 15:57

    Reply

    ok - now - after selecting "get distribution link" subaction
  21. Stefan Bürk uploaded patch set 7 V +1 01/23/24, 16:17

  22. core-ci voted on patch set 7 V +1 01/23/24, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52014

  23. Christian Kuhn voted on patch set 7 CR +1 V +1 01/23/24, 16:35

  24. Stefan Bürk voted on patch set 7 CR +2 V +2 01/23/24, 16:37

  25. Stefan Bürk merged patch set 8 01/23/24, 16:37