81948[TASK] Clean up extension manager code
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 27
- typo3/sysext/core/Classes/Database/Query/QueryBuilder.php+2 −2
- typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php+8 −9
- typo3/sysext/extensionmanager/Classes/Controller/UpdateFromTerController.php+0 −2
- typo3/sysext/extensionmanager/Classes/Domain/Model/Dependency.php+6 −30
- typo3/sysext/extensionmanager/Classes/Domain/Model/DownloadQueue.php2+15 −28
- typo3/sysext/extensionmanager/Classes/Domain/Model/Extension.php+71 −267
- typo3/sysext/extensionmanager/Classes/Domain/Repository/BulkExtensionRepositoryWriter.php+2 −0
- typo3/sysext/extensionmanager/Classes/Domain/Repository/ExtensionRepository.php+2 −0
- typo3/sysext/extensionmanager/Classes/Exception/ExtensionManagerException.php+2 −0
- typo3/sysext/extensionmanager/Classes/Exception/MissingExtensionDependencyException.php+2 −0
- typo3/sysext/extensionmanager/Classes/Exception/MissingVersionDependencyException.php+2 −0
- typo3/sysext/extensionmanager/Classes/Exception/UnresolvedDependencyException.php+2 −0
- typo3/sysext/extensionmanager/Classes/Exception/UnresolvedPhpDependencyException.php+2 −0
- typo3/sysext/extensionmanager/Classes/Exception/UnresolvedTypo3DependencyException.php+2 −0
- typo3/sysext/extensionmanager/Classes/Remote/TerExtensionRemote.php2+4 −15
- typo3/sysext/extensionmanager/Classes/Report/ExtensionStatus.php+2 −0
- typo3/sysext/extensionmanager/Classes/Service/ExtensionManagementService.php2+28 −115
- typo3/sysext/extensionmanager/Classes/Task/UpdateExtensionListTask.php+2 −0
- typo3/sysext/extensionmanager/Classes/Utility/DependencyUtility.php+2 −0
- typo3/sysext/extensionmanager/Classes/Utility/EmConfUtility.php+8 −12
Show 7 more files
- typo3/sysext/extensionmanager/Classes/Utility/FileHandlingUtility.php2+10 −25
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php+2 −3
- typo3/sysext/extensionmanager/Classes/Utility/ListUtility.php+11 −22
- typo3/sysext/extensionmanager/Classes/Exception.php+2 −0
- typo3/sysext/extensionmanager/Tests/Unit/Controller/DownloadControllerTest.php+1 −1
- typo3/sysext/extensionmanager/Tests/Unit/Service/ExtensionManagementServiceTest.php+6 −10
- typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php+0 −28
Review log 1825
-
Benni Mack uploaded patch set 1 11/24/23, 08:05
-
core-ci voted on patch set 1 V -1 11/24/23, 08:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49833
-
Benni Mack uploaded patch set 2
V -101/23/24, 11:05 -
core-ci voted on patch set 2 V +1 01/23/24, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51986
-
Benni Mack updated the commit message in patch set 3
V +101/23/24, 11:24 -
core-ci voted on patch set 3 V +1 01/23/24, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51988
-
Andreas Kienast commented on patch set 3 01/23/24, 13:21
ExtensionManagementService.php:2`declare(strict_types=1)`? -
Christian Kuhn commented on patch set 3 CR -1 01/23/24, 13:26
TerExtensionRemote.php:141$pathType argument unused. remove?FileHandlingUtility.php:44it looks as if this is never reset to anything else. Let's define this as private const to clarify this service is stateless (apart from the __construct() initialized LanguageService). -
Benni Mack uploaded patch set 4
CR -1V +101/23/24, 14:09 -
Benni Mack commented on patch set 4 01/23/24, 14:10
DownloadQueue.php:2ReplyDoneTerExtensionRemote.php:141Replyit's in the interface, so I want to keep it like this for the time beingExtensionManagementService.php:2ReplyDoneFileHandlingUtility.php:44ReplyDone -
Benni Mack updated the commit message in patch set 5 01/23/24, 14:11
-
core-ci voted on patch set 4 V -1 01/23/24, 14:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52001
-
core-ci voted on patch set 5 V -1 01/23/24, 14:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52003
-
Benni Mack uploaded patch set 6
V -101/23/24, 14:38 -
core-ci voted on patch set 6 V +1 01/23/24, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52007
-
Christian Kuhn voted on patch set 6 CR +1 V +1 01/23/24, 14:46
-
Andreas Kienast commented on patch set 6 V -1 01/23/24, 15:20
When opening the Extension Manager, I get ``` Typed property TYPO3\CMS\Extensionmanager\Domain\Model\Extension::$dependencies must not be accessed before initialization ``` -
Christian Kuhn voted on patch set 6 CR 0 V 0 01/23/24, 15:26
-
Stefan Bürk commented on patch set 6 01/23/24, 15:55
Reply
interessting - i'm not oO -
Stefan Bürk commented on patch set 6 01/23/24, 15:57
Reply
ok - now - after selecting "get distribution link" subaction -
Stefan Bürk uploaded patch set 7
V +101/23/24, 16:17 -
core-ci voted on patch set 7 V +1 01/23/24, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52014
-
Christian Kuhn voted on patch set 7 CR +1 V +1 01/23/24, 16:35
-
Stefan Bürk voted on patch set 7 CR +2 V +2 01/23/24, 16:37
-
Stefan Bürk merged patch set 8 01/23/24, 16:37
DownloadQueue.php:2