Review main Merged

81954[BUGFIX] Prevent TypeError in SystemInformationMenu

Oli Bartsch CR +2 V +2 Easy +5 −5 updated 11/24/23, 13:49

Commit message

In some cases the element might not be available,
making the  data attributes not accessible. To
prevent type errors, proper checks are added.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 11/24/23, 13:11

  2. Andreas Kienast voted on patch set 1 CR +1 V +1 11/24/23, 13:12

  3. core-ci voted on patch set 1 V +1 11/24/23, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49892

  4. Jochen Roth voted on patch set 1 CR +1 V +1 11/24/23, 13:43

  5. Oli Bartsch voted on patch set 1 CR +2 V +2 11/24/23, 13:49

  6. Oli Bartsch merged patch set 2 11/24/23, 13:49