Review main Merged

81955[TASK] Throw exception if `frontend.typoscript` is not available

Stefan Bürk CR +2 V +2 Easy +9 −2 updated 11/27/23, 11:56

Commit message

Extension authors tend to use extbase way out of the
feel well habitat, for example using extbase in PSR-7
middlewares before the required frontend context stack
is there.

Avoiding a fatal php error has been mitigated with #102457
but still leaves the extension in the delusion of a working
context.

This change checks if the `frontent.typoscript` is not set
in the request and throwing a speaking runtime exception.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1014

  1. Stefan Bürk uploaded patch set 1 11/24/23, 16:04

  2. core-ci voted on patch set 1 V +1 11/24/23, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49897

  3. Stefan Bürk rebased onto patch set 2 V +1 11/25/23, 16:24

  4. core-ci voted on patch set 2 V +1 11/25/23, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49933

  5. Stefan Bürk updated the commit message in patch set 3 V +1 11/25/23, 16:31

  6. core-ci voted on patch set 3 V +1 11/25/23, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49934

  7. Oliver Klee voted on patch set 3 CR +1 11/25/23, 18:40

  8. Simon Schaufelberger updated the commit message in patch set 4 CR +1 V +1 11/25/23, 20:07

  9. core-ci voted on patch set 4 V +1 11/25/23, 20:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49936

  10. Oliver Klee voted on patch set 4 CR +1 11/25/23, 20:35

  11. Christian Kuhn voted on patch set 4 CR +1 V +1 11/26/23, 10:17

  12. Benni Mack voted on patch set 4 CR +1 V +1 11/27/23, 11:46

  13. Christian Kuhn voted on patch set 4 CR +2 V +2 11/27/23, 11:56

  14. Christian Kuhn merged patch set 5 11/27/23, 11:56