81956[BUGFIX] Prevent JS SyntaxError on extension installation
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1519
-
Oli Bartsch uploaded patch set 1 11/24/23, 16:49
-
core-ci voted on patch set 1 V +1 11/24/23, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49898
-
Jochen Roth voted on patch set 1 CR +1 V +1 11/24/23, 17:01
-
Benjamin Franzke commented on patch set 1 CR -1 11/24/23, 17:06
-
Oli Bartsch uploaded patch set 2
CR +1V +111/24/23, 17:46 -
Oli Bartsch commented on patch set 2 11/24/23, 17:50
repository.ts:109ReplyTotally right. `try ... catch` is the way to go. Changed the patch accordingly. Please don't hesitate to adjust it, if you like. -
core-ci voted on patch set 2 V +1 11/24/23, 17:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49900
-
Oli Bartsch uploaded patch set 3
V +111/24/23, 17:52 -
core-ci voted on patch set 3 V +1 11/24/23, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49901
-
Christian Kuhn voted on patch set 3 CR +1 V +1 11/25/23, 15:24
-
Jochen Roth voted on patch set 3 CR +1 V +1 11/25/23, 18:19
-
Simon Schaufelberger commented on patch set 3 11/25/23, 20:14
An extension. since the patch has already some positive votes, I don't want to destroy them again. -
Oli Bartsch updated the commit message in patch set 4
CR +1V +111/26/23, 17:50 -
Oli Bartsch commented on patch set 4 11/26/23, 17:52
Reply
Thanks for the hint. -
core-ci voted on patch set 4 V +1 11/26/23, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49952
-
Jochen Roth voted on patch set 4 CR +1 V +1 11/26/23, 18:16
-
Christian Kuhn voted on patch set 4 CR +1 V +1 11/26/23, 18:49
-
Oli Bartsch voted on patch set 4 CR +2 V +2 11/26/23, 19:51
-
Oli Bartsch merged patch set 5 11/26/23, 19:51
repository.ts:109