Review main Merged

81957[TASK] Avoid $GLOBALS['TYPO3_REQUEST'] in BackendConfigurationManager

Oli Bartsch CR +2 V +2 Easy +19 −24 updated 11/25/23, 15:09

Commit message

Avoid the $GLOBALS['TYPO3_REQUEST fallback
and use the class variable directly.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Oli Bartsch uploaded patch set 1 11/24/23, 17:28

  2. core-ci voted on patch set 1 V +1 11/24/23, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49899

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 11/25/23, 14:56

  4. Stefan Bürk voted on patch set 1 CR +2 V +2 11/25/23, 15:09

  5. Stefan Bürk merged patch set 2 11/25/23, 15:09